mirror of
https://github.com/fadden/6502bench.git
synced 2024-07-07 07:28:57 +00:00
b387298685
In 1.5.0-dev1, as part of changes to the way label localization works, the local variable de-duplicator started checking against a filtered copy of the symbol table. Unfortunately it never re-generated the table, so a long-lived LocalVariableLookup (like the one used by LineListGen) would set up the dup map wrong and be inconsistent with other parts of the program. We now regenerate the table on every Reset(). The de-duplication stuff also had problems when opcodes and operands were double-clicked on. When the opcode is clicked, the selection should jump to the appropriate variable declaration, but it wasn't being found because the label generated in the list was in its original form. Fixed. When an instruction operand is double-clicked, the instruction operand editor opens with an "edit variable" shortcut. This was showing the de-duplicated name, which isn't necessarily a bad thing, but it was passing that value on to the DefSymbol editor, which thought it was being asked to create a new entry. Fixed. (Entering the editor through the LvTable editor works correctly, with nary a de-duplicated name in sight. You'll be forced to rename it because it'll fail the uniqueness test.) References to de-duplicated local variables were getting lost when the symbol's label was replaced (due largely to a convenient but flawed shortcut: xrefs are attached to DefSymbol objects). Fixed by linking the XrefSets. Given the many issues and their relative subtlety, I decided to make the modified names more obvious, and went back to the "_DUPn" naming strategy. (I'm also considering just making it an error and discarding conflicting entries during analysis... this is much more complicated than I expected it to be.) Quick tests can be performed in 2019-local-variables: - go to +000026, double-click on the opcode, confirm sel change - go to +000026, double-click on the operand, confirm orig name shown in shortcut and that shortcut opens editor with orig name - go to +00001a, down a line, click on PROJ_ZERO_DUP1 and confirm that it has a single reference (from +000026) - double-click on var table and confirm editing entry |
||
|---|---|---|
| .. | ||
| AsmGen | ||
| Examples | ||
| Properties | ||
| Res | ||
| RuntimeData | ||
| Sandbox | ||
| SGTestData | ||
| Tests | ||
| Tools | ||
| WpfGui | ||
| Anattrib.cs | ||
| App.config | ||
| App.xaml | ||
| App.xaml.cs | ||
| AppSettings.cs | ||
| AutoLabel.cs | ||
| ChangeSet.cs | ||
| CodeAnalysis.cs | ||
| DataAnalysis.cs | ||
| DefSymbol.cs | ||
| DisasmProject.cs | ||
| DisplayList.cs | ||
| DisplayListSelection.cs | ||
| Exporter.cs | ||
| ExternalFile.cs | ||
| FormatDescriptor.cs | ||
| FormattedOperandCache.cs | ||
| HelpAccess.cs | ||
| LineListGen.cs | ||
| LocalVariableLookup.cs | ||
| LocalVariableTable.cs | ||
| MainController.cs | ||
| MessageList.cs | ||
| MultiLineComment.cs | ||
| NavStack.cs | ||
| PlatformSymbols.cs | ||
| ProjectFile.cs | ||
| ProjectProperties.cs | ||
| PseudoOp.cs | ||
| RuntimeDataAccess.cs | ||
| SourceGen.csproj | ||
| Symbol.cs | ||
| SymbolTable.cs | ||
| SystemDefaults.cs | ||
| SystemDefs.cs | ||
| UndoableChange.cs | ||
| Visualization.cs | ||
| VisualizationAnimation.cs | ||
| VisualizationSet.cs | ||
| WeakSymbolRef.cs | ||
| XrefSet.cs | ||