diff --git a/doc/notes.txt b/doc/notes.txt index 4b434136..f8eaddff 100644 --- a/doc/notes.txt +++ b/doc/notes.txt @@ -129,17 +129,13 @@ TODO: - show cur/tmp vram addresses - NES crt should mark raster pos when debugging - OAMDMA in profiler? (haltCycles) - - ca65 skeleton - - neslib.cfg nesbanked.cfg ZP segment is C64-ish, should use $00-$FF - JSNES - doesn't support hiding >8 sprites - doesn't do sprite zero test right - doesn't do clip right - doesn't do b/w tint - vcs - - sound doesn't start on Chrome (https://goo.gl/7K7WLu) - - make start after clicking in embed - - vcs sound continues when paused + - sometimes still plays when paused on FF - vcs: INPTx needs to be added to control state - vcs: break on # of lines changed (maybe using getRasterPosition?) - chrome looks blurry on vcs @@ -156,7 +152,6 @@ TODO: - test offline? (if window.firebase) - Github - platform_id/repo.platform mismatch (can't leave repository) - - gh-pages branch with embedded - handle overwrite logic - what to do about included files? - can published files retain path? @@ -164,7 +159,6 @@ TODO: - CORS for some blobs? - don't import useless files - support projects with subdirectories, file list? - - emulator needs reset shortcut for nes - switching platform of a repo? - make sure to flatten subdirs - astrocade @@ -181,8 +175,7 @@ TODO: - can't step back twice? - compiler bug in chase - "shared" in URL doesn't work, leave in URL? (also importURL) -- vicdual: delay is faster - + - alert when skeleton file loaded or file not found WEB WORKER FORMAT diff --git a/src/platform/vcs.ts b/src/platform/vcs.ts index 3e9fb979..2cf47ce8 100644 --- a/src/platform/vcs.ts +++ b/src/platform/vcs.ts @@ -69,8 +69,6 @@ class VCSPlatform extends BasePlatform { var self = this; $("#javatari-div").show(); Javatari.start(); - // for Chrome autostart - Javatari.room.speaker.powerOff(); // intercept clockPulse function Javatari.room.console.oldClockPulse = Javatari.room.console.clockPulse; Javatari.room.console.clockPulse = function() { @@ -129,9 +127,12 @@ class VCSPlatform extends BasePlatform { } pause() { Javatari.room.console.pause(); + Javatari.room.speaker.mute(); } resume() { Javatari.room.console.go(); + // for browser autostart + Javatari.room.speaker.powerOff(); Javatari.room.speaker.powerOn(); } advance() { diff --git a/src/services.ts b/src/services.ts index 02d89462..7bc4049c 100644 --- a/src/services.ts +++ b/src/services.ts @@ -206,7 +206,6 @@ export class GithubService { sess.platform_id = m[1]; } // bind to repository - // TODO: don't bind until successful first import this.bind(sess, true); // get head commit return sess; diff --git a/src/ui.ts b/src/ui.ts index 9eafdec2..f80d72cf 100644 --- a/src/ui.ts +++ b/src/ui.ts @@ -454,6 +454,7 @@ function importProjectFromGithub(githuburl:string, replaceURL:boolean) { gotoNewLocation(replaceURL); }).catch( (e) => { setWaitDialog(false); + if (sess) getGithubService().bind(sess, false); console.log(e); alertError("

Could not import " + githuburl + ".

" + e); });