6502/CLK
1
0
Fork 0
mirror of https://github.com/TomHarte/CLK.git synced 2025-02-03 22:33:29 +00:00
Code Issues Projects Releases Wiki Activity

Resolves a potential out-of-bounds array access.

Browse Source 
Risk was: allocation exactly joins end of buffer. In which case the next get_data won't wrap the texture y coordinate since it won't spot an x overage.
This commit is contained in:
Thomas Harte 2019-11-05 21:47:40 -05:00
parent f4556ef6b0
commit 35f1a7ab10
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Outputs/OpenGL/ScanTarget.cpp
View File

@ -229,8 +229,10 @@ void ScanTarget::end_data(size_t actual_length) {
data_type_size_);
// The write area was allocated in the knowledge that there's sufficient
// distance left on the current line, so there's no need to worry about carry.
// distance left on the current line, but there's a risk of exactly filling
// the final line, in which case this should wrap back to 0.
write_pointers_.write_area += actual_length + 1;
write_pointers_.write_area %= write_area_texture_.size();
// Also bookend the end.
memcpy(