6502/CLK
1
0
Fork 0
mirror of https://github.com/TomHarte/CLK.git synced 2025-10-31 05:16:08 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #1309 from TomHarte/TypeWarnings

Browse Source 
Resolve minor dangling type conversion warnings.
This commit is contained in:
Thomas Harte
2024-01-17 10:22:13 -05:00
committed by GitHub
parent 20c1f4f0e5 a402e30edf
commit 3ee81efe40
3 changed files with 38 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
Analyser/Static/Disassembler/Z80.cpp
View File

@@ -56,11 +56,11 @@ class Accessor {
bool overrun_ = false; bool overrun_ = false;
}; };
#define x(v) (v >> 6) constexpr uint8_t x(uint8_t v) { return v >> 6; }
#define y(v) ((v >> 3) & 7) constexpr uint8_t y(uint8_t v) { return (v >> 3) & 7; }
#define q(v) ((v >> 3) & 1) constexpr uint8_t q(uint8_t v) { return (v >> 3) & 1; }
#define p(v) ((v >> 4) & 3) constexpr uint8_t p(uint8_t v) { return (v >> 4) & 3; }
#define z(v) (v & 7) constexpr uint8_t z(uint8_t v) { return v & 7; }
Instruction::Condition condition_table[] = { Instruction::Condition condition_table[] = {
Instruction::Condition::NZ, Instruction::Condition::Z, Instruction::Condition::NZ, Instruction::Condition::Z,

5
Machines/Apple/AppleIIgs/Video.cpp
View File

@@ -279,7 +279,10 @@ void Video::output_row(int row, int start, int end) {
line_control_ = ram_[0x19d00 + row]; line_control_ = ram_[0x19d00 + row];
const int palette_base = (line_control_ & 15) * 32 + 0x19e00; const int palette_base = (line_control_ & 15) * 32 + 0x19e00;
for(int c = 0; c < 16; c++) { for(int c = 0; c < 16; c++) {
const int entry = ram_[palette_base + (c << 1)] | (ram_[palette_base + (c << 1) + 1] << 8); const auto entry = uint16_t(
ram_[palette_base + (c << 1)] |
(ram_[palette_base + (c << 1) + 1] << 8)
);
palette_[c] = convulve(entry); palette_[c] = convulve(entry);
} }

55
Machines/Sinclair/ZXSpectrum/ZXSpectrum.cpp
View File

@@ -200,7 +200,7 @@ template<Model model> class ConcreteMachine:
if(model <= Model::FortyEightK) { if(model <= Model::FortyEightK) {
const size_t num_banks = std::min(size_t(48*1024), state->ram.size()) >> 14; const size_t num_banks = std::min(size_t(48*1024), state->ram.size()) >> 14;
for(size_t c = 0; c < num_banks; c++) { for(size_t c = 0; c < num_banks; c++) {
memcpy(&write_pointers_[c + 1][(c+1) * 0x4000], &state->ram[c * 0x4000], 0x4000); memcpy(&banks_[c + 1].write[(c+1) * 0x4000], &state->ram[c * 0x4000], 0x4000);
} }
} else { } else {
memcpy(ram_.data(), state->ram.data(), std::min(ram_.size(), state->ram.size())); memcpy(ram_.data(), state->ram.data(), std::min(ram_.size(), state->ram.size()));
@@ -309,7 +309,7 @@ template<Model model> class ConcreteMachine:
// Model applied: the trigger for the ULA inserting a delay is the falling edge // Model applied: the trigger for the ULA inserting a delay is the falling edge
// of MREQ, which is always half a cycle into a read or write. // of MREQ, which is always half a cycle into a read or write.
if( if(
is_contended_[address >> 14] && banks_[address >> 14].is_contended &&
cycle.operation >= PartialMachineCycle::ReadOpcodeStart && cycle.operation >= PartialMachineCycle::ReadOpcodeStart &&
cycle.operation <= PartialMachineCycle::WriteStart) { cycle.operation <= PartialMachineCycle::WriteStart) {
@@ -363,7 +363,7 @@ template<Model model> class ConcreteMachine:
case PartialMachineCycle::WriteStart: { case PartialMachineCycle::WriteStart: {
// These all start by loading the address bus, then set MREQ // These all start by loading the address bus, then set MREQ
// half a cycle later. // half a cycle later.
if(is_contended_[address >> 14]) { if(banks_[address >> 14].is_contended) {
const auto delay = video_.last_valid()->access_delay(video_.time_since_flush()); const auto delay = video_.last_valid()->access_delay(video_.time_since_flush());
advance(cycle.length + delay); advance(cycle.length + delay);
@@ -375,7 +375,7 @@ template<Model model> class ConcreteMachine:
// Whatever's on the address bus will remain there, without IOREQ or // Whatever's on the address bus will remain there, without IOREQ or
// MREQ interceding, for this entire bus cycle. So apply contentions // MREQ interceding, for this entire bus cycle. So apply contentions
// all the way along. // all the way along.
if(is_contended_[address >> 14]) { if(banks_[address >> 14].is_contended) {
const auto half_cycles = cycle.length.as<int>(); const auto half_cycles = cycle.length.as<int>();
assert(!(half_cycles & 1)); assert(!(half_cycles & 1));
@@ -405,7 +405,7 @@ template<Model model> class ConcreteMachine:
// Fast loading: ROM version. // Fast loading: ROM version.
// //
// The below patches over part of the 'LD-BYTES' routine from the 48kb ROM. // The below patches over part of the 'LD-BYTES' routine from the 48kb ROM.
if(use_fast_tape_hack_ && address == 0x056b && read_pointers_[0] == &rom_[classic_rom_offset()]) { if(use_fast_tape_hack_ && address == 0x056b && banks_[0].read == &rom_[classic_rom_offset()]) {
// Stop pressing enter, if neccessry. // Stop pressing enter, if neccessry.
if(duration_to_press_enter_ > Cycles(0)) { if(duration_to_press_enter_ > Cycles(0)) {
duration_to_press_enter_ = Cycles(0); duration_to_press_enter_ = Cycles(0);
@@ -429,10 +429,10 @@ template<Model model> class ConcreteMachine:
} }
} }
*cycle.value = read_pointers_[address >> 14][address]; *cycle.value = banks_[address >> 14].read[address];
if constexpr (model >= Model::Plus2a) { if constexpr (model >= Model::Plus2a) {
if(is_contended_[address >> 14]) { if(banks_[address >> 14].is_contended) {
video_->set_last_contended_area_access(*cycle.value); video_->set_last_contended_area_access(*cycle.value);
} }
} }
@@ -440,15 +440,15 @@ template<Model model> class ConcreteMachine:
case PartialMachineCycle::Write: case PartialMachineCycle::Write:
// Flush video if this access modifies screen contents. // Flush video if this access modifies screen contents.
if(is_video_[address >> 14] && (address & 0x3fff) < 6912) { if(banks_[address >> 14].is_video && (address & 0x3fff) < 6912) {
video_.flush(); video_.flush();
} }
write_pointers_[address >> 14][address] = *cycle.value; banks_[address >> 14].write[address] = *cycle.value;
if constexpr (model >= Model::Plus2a) { if constexpr (model >= Model::Plus2a) {
// Fill the floating bus buffer if this write is within the contended area. // Fill the floating bus buffer if this write is within the contended area.
if(is_contended_[address >> 14]) { if(banks_[address >> 14].is_contended) {
video_->set_last_contended_area_access(*cycle.value); video_->set_last_contended_area_access(*cycle.value);
} }
} }
@@ -758,11 +758,14 @@ template<Model model> class ConcreteMachine:
std::array<uint8_t, 128*1024> ram_; std::array<uint8_t, 128*1024> ram_;
std::array<uint8_t, 16*1024> scratch_; std::array<uint8_t, 16*1024> scratch_;
std::array<const uint8_t *, 4> read_pointers_; struct Bank {
std::array<uint8_t *, 4> write_pointers_; const uint8_t * read;
std::array<uint8_t, 4> pages_; uint8_t *write;
std::array<bool, 4> is_contended_; uint8_t page;
std::array<bool, 4> is_video_; bool is_contended;
bool is_video;
};
std::array<Bank, 4> banks_;
uint8_t port1ffd_ = 0; uint8_t port1ffd_ = 0;
uint8_t port7ffd_ = 0; uint8_t port7ffd_ = 0;
@@ -821,19 +824,19 @@ template<Model model> class ConcreteMachine:
disable_paging_ = port7ffd_ & 0x20; disable_paging_ = port7ffd_ & 0x20;
} }
void set_memory(int bank, uint8_t source) { void set_memory(std::size_t bank, uint8_t source) {
if constexpr (model >= Model::Plus2a) { if constexpr (model >= Model::Plus2a) {
is_contended_[bank] = source >= 4 && source < 8; banks_[bank].is_contended = source >= 4 && source < 8;
} else { } else {
is_contended_[bank] = source < 0x80 && source & 1; banks_[bank].is_contended = source < 0x80 && source & 1;
} }
pages_[bank] = source; banks_[bank].page = source;
uint8_t *const read = (source < 0x80) ? &ram_[source * 16384] : &rom_[(source & 0x7f) * 16384]; uint8_t *const read = (source < 0x80) ? &ram_[source * 16384] : &rom_[(source & 0x7f) * 16384];
const auto offset = bank*16384; const auto offset = bank*16384;
read_pointers_[bank] = read - offset; banks_[bank].read = read - offset;
write_pointers_[bank] = ((source < 0x80) ? read : scratch_.data()) - offset; banks_[bank].write = ((source < 0x80) ? read : scratch_.data()) - offset;
} }
void set_video_address() { void set_video_address() {
@@ -843,10 +846,10 @@ template<Model model> class ConcreteMachine:
void update_video_base() { void update_video_base() {
const uint8_t video_page = (port7ffd_ & 0x08) ? 7 : 5; const uint8_t video_page = (port7ffd_ & 0x08) ? 7 : 5;
is_video_[0] = pages_[0] == video_page; banks_[0].is_video = banks_[0].page == video_page;
is_video_[1] = pages_[1] == video_page; banks_[1].is_video = banks_[1].page == video_page;
is_video_[2] = pages_[2] == video_page; banks_[2].is_video = banks_[2].page == video_page;
is_video_[3] = pages_[3] == video_page; banks_[3].is_video = banks_[3].page == video_page;
} }
// MARK: - Audio. // MARK: - Audio.
@@ -934,7 +937,7 @@ template<Model model> class ConcreteMachine:
break; break;
} }
write_pointers_[target >> 14][target] = *next; banks_[target >> 14].write[target] = *next;
parity ^= *next; parity ^= *next;
++target; ++target;
} }