6502/CLK
1
0
Fork 0
mirror of https://github.com/TomHarte/CLK.git synced 2025-01-30 11:34:54 +00:00
Code Issues Projects Releases Wiki Activity

Simplify roll/shift case.

Browse Source
This commit is contained in:
Thomas Harte 2023-10-05 09:26:12 -04:00
parent f6fd49d950
commit 6597283c34
1 changed files with 13 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
InstructionSets/x86/Instruction.cpp
View File

@ -530,28 +530,19 @@ std::string InstructionSet::x86::to_string(
case Operation::SAL: case Operation::SAR:
case Operation::SHR:
case Operation::SETMO: case Operation::SETMOC:
const int operands = max_displayed_operands(instruction.operation);
const bool displacement = has_displacement(instruction.operation);
if(operands > 1) {
operation += to_string(instruction.destination(), instruction, offset_length, immediate_length);
}
if(operands > 0) {
switch(instruction.source().source()) {
case Source::None: break;
case Source::eCX: operation += ", cl"; break;
case Source::Immediate:
// Providing an immediate operand of 1 is a little future-proofing by the decoder; the '1'
// is actually implicit on a real 8088. So omit it.
if(instruction.operand() == 1) break;
[[fallthrough]];
default:
operation += ", ";
operation += to_string(instruction.source(), instruction, offset_length, immediate_length);
break;
}
}
if(displacement) {
operation += to_hex(instruction.displacement(), offset_length);
operation += to_string(instruction.destination(), instruction, offset_length, immediate_length);
switch(instruction.source().source()) {
case Source::None: break;
case Source::eCX: operation += ", cl"; break;
case Source::Immediate:
// Providing an immediate operand of 1 is a little future-proofing by the decoder; the '1'
// is actually implicit on a real 8088. So omit it.
if(instruction.operand() == 1) break;
[[fallthrough]];
default:
operation += ", ";
operation += to_string(instruction.source(), instruction, offset_length, immediate_length);
break;
}
break;
}