From 6bc66d8b962e47a94b04a006e8e2b1e638725b0a Mon Sep 17 00:00:00 2001
From: Thomas Harte <thomas.harte@gmail.com>
Date: Wed, 29 Jul 2020 23:18:03 -0400
Subject: [PATCH] Tidies, ensures ::will_change_owner acquires the producer
 mutex.

---
 .../xcshareddata/xcschemes/Clock Signal.xcscheme       |  2 +-
 Outputs/ScanTargets/BufferingScanTarget.cpp            | 10 ++++++++--
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/OSBindings/Mac/Clock Signal.xcodeproj/xcshareddata/xcschemes/Clock Signal.xcscheme b/OSBindings/Mac/Clock Signal.xcodeproj/xcshareddata/xcschemes/Clock Signal.xcscheme
index 63be2c037..a99eb0a5d 100644
--- a/OSBindings/Mac/Clock Signal.xcodeproj/xcshareddata/xcschemes/Clock Signal.xcscheme	
+++ b/OSBindings/Mac/Clock Signal.xcodeproj/xcshareddata/xcschemes/Clock Signal.xcscheme	
@@ -67,7 +67,7 @@
       </Testables>
    </TestAction>
    <LaunchAction
-      buildConfiguration = "Debug"
+      buildConfiguration = "Release"
       selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
       selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
       enableASanStackUseAfterReturn = "YES"
diff --git a/Outputs/ScanTargets/BufferingScanTarget.cpp b/Outputs/ScanTargets/BufferingScanTarget.cpp
index a0930ccdb..96b9f5bf1 100644
--- a/Outputs/ScanTargets/BufferingScanTarget.cpp
+++ b/Outputs/ScanTargets/BufferingScanTarget.cpp
@@ -212,8 +212,9 @@ void BufferingScanTarget::announce(Event event, bool is_visible, const Outputs::
 		// Commit the most recent line only if any scans fell on it and all allocation was successful.
 		if(!allocation_has_failed_ && provided_scans_) {
 			// Store metadata.
-			line_metadata_buffer_[size_t(write_pointers_.line)].is_first_in_frame = is_first_in_frame_;
-			line_metadata_buffer_[size_t(write_pointers_.line)].previous_frame_was_complete = previous_frame_was_complete_;
+			LineMetadata &metadata = line_metadata_buffer_[size_t(write_pointers_.line)];
+			metadata.is_first_in_frame = is_first_in_frame_;
+			metadata.previous_frame_was_complete = previous_frame_was_complete_;
 			is_first_in_frame_ = false;
 
 			// Store actual line data.
@@ -244,6 +245,7 @@ void BufferingScanTarget::announce(Event event, bool is_visible, const Outputs::
 // MARK: - Producer; other state.
 
 void BufferingScanTarget::will_change_owner() {
+	std::lock_guard lock_guard(producer_mutex_);
 	allocation_has_failed_ = true;
 	vended_scan_ = nullptr;
 }
@@ -264,9 +266,13 @@ void BufferingScanTarget::set_write_area(uint8_t *base) {
 	write_area_ = base;
 	data_type_size_ = Outputs::Display::size_for_data_type(modals_.input_data_type);
 	write_pointers_ = submit_pointers_ = read_pointers_ = PointerSet();
+	allocation_has_failed_ = true;
+	vended_scan_ = nullptr;
 }
 
 size_t BufferingScanTarget::write_area_data_size() const {
+	// TODO: can I guarantee this is safe without requiring that set_write_area
+	// be within an @c perform block?
 	return data_type_size_;
 }