From 7017324d60a5dbdc95a65468bdcbef7babf1750c Mon Sep 17 00:00:00 2001 From: Thomas Harte Date: Tue, 13 Apr 2021 22:17:30 -0400 Subject: [PATCH] `r_step` is obsolete now that I know that [DD/FD]CB don't have a refresh cycle. --- Processors/Z80/Implementation/Z80Implementation.hpp | 2 +- Processors/Z80/Implementation/Z80Storage.cpp | 3 --- Processors/Z80/Implementation/Z80Storage.hpp | 1 - 3 files changed, 1 insertion(+), 5 deletions(-) diff --git a/Processors/Z80/Implementation/Z80Implementation.hpp b/Processors/Z80/Implementation/Z80Implementation.hpp index 12f637ca5..490e5f50f 100644 --- a/Processors/Z80/Implementation/Z80Implementation.hpp +++ b/Processors/Z80/Implementation/Z80Implementation.hpp @@ -94,7 +94,7 @@ template < class T, break; case MicroOp::IncrementR: refresh_addr_ = ir_; - ir_.halves.low = (ir_.halves.low & 0x80) | ((ir_.halves.low + current_instruction_page_->r_step) & 0x7f); + ir_.halves.low = (ir_.halves.low & 0x80) | ((ir_.halves.low + 1) & 0x7f); break; case MicroOp::DecodeOperation: pc_.full += pc_increment_ & uint16_t(halt_mask_); diff --git a/Processors/Z80/Implementation/Z80Storage.cpp b/Processors/Z80/Implementation/Z80Storage.cpp index c4ef81184..8f2404ed8 100644 --- a/Processors/Z80/Implementation/Z80Storage.cpp +++ b/Processors/Z80/Implementation/Z80Storage.cpp @@ -153,11 +153,8 @@ void ProcessorStorage::install_default_instruction_set() { assemble_base_page(fd_page_, iy_, true, fdcb_page_); assemble_ed_page(ed_page_); - fdcb_page_.r_step = 0; fd_page_.is_indexed = true; fdcb_page_.is_indexed = true; - - ddcb_page_.r_step = 0; dd_page_.is_indexed = true; ddcb_page_.is_indexed = true; diff --git a/Processors/Z80/Implementation/Z80Storage.hpp b/Processors/Z80/Implementation/Z80Storage.hpp index e107ef312..613e9334a 100644 --- a/Processors/Z80/Implementation/Z80Storage.hpp +++ b/Processors/Z80/Implementation/Z80Storage.hpp @@ -121,7 +121,6 @@ class ProcessorStorage { std::vector all_operations; std::vector fetch_decode_execute; MicroOp *fetch_decode_execute_data = nullptr; - uint8_t r_step = 1; bool is_indexed = false; };