6502/CLK
1
0
Fork 0
mirror of https://github.com/TomHarte/CLK.git synced 2025-01-27 06:35:04 +00:00
Code Issues Projects Releases Wiki Activity

Eliminates repetition of the 10 constant.

Browse Source
This commit is contained in:
Thomas Harte 2018-06-14 17:23:47 -04:00
parent eff67f2250
commit 7728adfc5a
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Machines/AmstradCPC/AmstradCPC.cpp
View File

@ -546,14 +546,14 @@ class KeyboardState: public GI::AY38910::PortHandler {
Sets the row currently being reported to the AY.
*/
void set_row(int row) {
row_ = row;
row_ = static_cast<size_t>(row);
}
/*!
Reports the state of the currently-selected row as Port A to the AY.
*/
uint8_t get_port_input(bool port_b) {
if(!port_b && row_ < 10) {
if(!port_b && row_ < sizeof(rows_)) {
return rows_[row_];
}
@ -565,7 +565,7 @@ class KeyboardState: public GI::AY38910::PortHandler {
*/
void set_is_pressed(bool is_pressed, int line, int key) {
int mask = 1 << key;
assert(line < 10);
assert(static_cast<size_t>(line) < sizeof(rows_));
if(is_pressed) rows_[line] &= ~mask; else rows_[line] |= mask;
}
@ -573,12 +573,12 @@ class KeyboardState: public GI::AY38910::PortHandler {
Sets all keys as currently unpressed.
*/
void clear_all_keys() {
memset(rows_, 0xff, 10);
memset(rows_, 0xff, sizeof(rows_));
}
private:
uint8_t rows_[10];
int row_;
size_t row_;
};
/*!