6502/CLK
1
0
Fork 0
mirror of https://github.com/TomHarte/CLK.git synced 2025-02-21 05:29:13 +00:00
Code Issues Projects Releases Wiki Activity

Fix CHK operand size.

Browse Source
This commit is contained in:
Thomas Harte 2022-05-07 21:16:44 -04:00
parent bf8c97abbb
commit 98cb9cc1eb
2 changed files with 3 additions and 56 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
InstructionSets/M68k/Instruction.hpp
View File

@ -166,7 +166,6 @@ constexpr DataSize operand_size(Operation operation) {
case Operation::ROXLb: case Operation::ROXRb:
case Operation::ANDb: case Operation::EORb:
case Operation::NOTb: case Operation::ORb:
case Operation::CHK:
case Operation::TAS:
return DataSize::Byte;
@ -205,6 +204,7 @@ constexpr DataSize operand_size(Operation operation) {
case Operation::MULU: case Operation::MULS:
case Operation::EXTbtow:
case Operation::LINKw:
case Operation::CHK:
return DataSize::Word;
case Operation::ADDl: case Operation::ADDAl:

57
OSBindings/Mac/Clock SignalTests/68000ComparativeTests.mm
View File

@ -28,63 +28,10 @@
NSMutableArray<NSNumber *> *_failingOpcodes;
}
// New implementation verified against (i.e. has the same failures as the old, likely all BCD related):
//
// add_sub
// addi_subi_cmpi
// eor_and_or
// addq_subq
// addx_subx
// bcc
// cmp
// dbcc_scc
// eori_andi_ori
// lea
// lslr_aslr_roxlr_rolr
// move_tofrom_srccr
// move
// movem
// movep
// moveq
// mulu_muls
// neg_not
// negx_clr
// swap
// tas
// tst
// rts
// rtr
// Issues to fix:
//
// LINK A7, in which the post-operation writeback overwrites
// the modified value.
//
// Do I need a dedicated LINKA7 operation?
//
// This affects link_unlk
// Skipped for now, for implying a more granular decoder:
//
// btst_bchg_bclr_bset
// chk
//
// And for uncertainty around the test result status register correctness:
//
// divu_divs
// eor_and_or (which invokes BCD)
// exg (also BCD)
// chk
// nbcd_pea (BCD)
//
// And because possibly my old CHK is pushing the wrong program counter?
//
// ext.json
- (void)setUp {
// To limit tests run to a subset of files and/or of tests, uncomment and fill in below.
_fileSet = [NSSet setWithArray:@[@"ext.json"]];
// _testSet = [NSSet setWithArray:@[@"NEGX 00c0"]];
// _fileSet = [NSSet setWithArray:@[@"chk.json"]];
// _testSet = [NSSet setWithArray:@[@"CHK 4190"]];
// _fileSet = [NSSet setWithArray:@[@"jmp_jsr.json"]];
// _testSet = [NSSet setWithArray:@[@"CHK 41a8"]];
}