From bee094eba156565f34b36feca33b73f69f5a268f Mon Sep 17 00:00:00 2001
From: Thomas Harte <thomas.harte@gmail.com>
Date: Fri, 20 Oct 2023 17:13:56 -0400
Subject: [PATCH] Add LODS; somehow manage to fail some of its tests.

---
 .../Implementation/PerformImplementation.hpp  | 19 +++++++++++++++++++
 OSBindings/Mac/Clock SignalTests/8088Tests.mm |  5 ++++-
 2 files changed, 23 insertions(+), 1 deletion(-)

diff --git a/InstructionSets/x86/Implementation/PerformImplementation.hpp b/InstructionSets/x86/Implementation/PerformImplementation.hpp
index 357be1fa7..f79aba401 100644
--- a/InstructionSets/x86/Implementation/PerformImplementation.hpp
+++ b/InstructionSets/x86/Implementation/PerformImplementation.hpp
@@ -1390,6 +1390,22 @@ void cmps(const InstructionT &instruction, AddressT &eCX, AddressT &eSI, Address
 	repeat<AddressT>(instruction, status, eCX, flow_controller);
 }
 
+template <typename IntT, typename AddressT, typename InstructionT, typename MemoryT, typename FlowControllerT>
+void lods(const InstructionT &instruction, AddressT &eCX, AddressT &eSI, IntT &eAX, MemoryT &memory, Status &status, FlowControllerT &flow_controller) {
+	if(repetition_over<AddressT>(instruction, eCX)) {
+		return;
+	}
+
+	Source source_segment = instruction.segment_override();
+	if(source_segment == Source::None) source_segment = Source::DS;
+
+	eAX = memory.template access<IntT>(source_segment, eSI);
+	eSI += status.direction<AddressT>() * sizeof(IntT);
+
+	repeat<AddressT>(instruction, status, eCX, flow_controller);
+}
+
+
 }
 
 template <
@@ -1633,6 +1649,9 @@ template <
 		case Operation::CMPS:
 			Primitive::cmps<IntT, AddressT>(instruction, eCX(), eSI(), eDI(), memory, status, flow_controller);
 		break;
+		case Operation::LODS:
+			Primitive::lods<IntT, AddressT>(instruction, eCX(), eSI(), pair_low(), memory, status, flow_controller);
+		break;
 	}
 
 	// Write to memory if required to complete this operation.
diff --git a/OSBindings/Mac/Clock SignalTests/8088Tests.mm b/OSBindings/Mac/Clock SignalTests/8088Tests.mm
index aabff09fd..a555f6ec0 100644
--- a/OSBindings/Mac/Clock SignalTests/8088Tests.mm	
+++ b/OSBindings/Mac/Clock SignalTests/8088Tests.mm	
@@ -401,10 +401,13 @@ struct FailedExecution {
 		@"C4.json.gz",	// LES
 		@"8D.json.gz",	// LEA
 
-		// TODO: LODS, MOVS, SCAS, STOS
+		// TODO: MOVS, SCAS, STOS
 */
 		// CMPS
 		@"A6.json.gz",	@"A7.json.gz",
+
+		// LODS
+		@"AC.json.gz",	@"AD.json.gz",
 /*
 		@"E0.json.gz",	// LOOPNE
 		@"E1.json.gz",	// LOOPE