6502/CLK
1
0
Fork 0
mirror of https://github.com/TomHarte/CLK.git synced 2024-10-02 19:54:35 +00:00
Code Issues Projects Releases Wiki Activity

Factors out command termination, adds a default implementation of test unit ready.

Browse Source
This commit is contained in:
Thomas Harte 2019-09-03 22:40:18 -04:00
parent a4ab0afce3
commit cbd1a8cf78
2 changed files with 16 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Storage/MassStorage/SCSI/DirectAccessDevice.cpp
View File

@ -19,11 +19,7 @@ bool DirectAccessDevice::read(const Target::CommandState &state, Target::Respond
if(!device_) return false;
responder.send_data(device_->get_block(state.address()), [] (const Target::CommandState &state, Target::Responder &responder) {
responder.send_message(Target::Responder::Message::CommandComplete, [] (const Target::CommandState &state, Target::Responder &responder) {
responder.send_status(Target::Responder::Status::Good, [] (const Target::CommandState &state, Target::Responder &responder) {
responder.end_command();
});
});
responder.terminate_command(Target::Responder::Status::Good);
});
return true;

16
Storage/MassStorage/SCSI/Target.hpp
View File

@ -79,6 +79,16 @@ struct Responder {
Ends the SCSI command.
*/
virtual void end_command() = 0;
/*!
Terminates a SCSI command, sending the proper sequence of status and message phases.
*/
void terminate_command(Status status) {
send_message(Target::Responder::Message::CommandComplete, [status] (const Target::CommandState &state, Target::Responder &responder) {
responder.send_status(status, [] (const Target::CommandState &state, Target::Responder &responder) {
responder.end_command();
});
});
}
};
/*!
@ -92,7 +102,11 @@ struct Responder {
*/
struct Executor {
/* Group 0 commands. */
bool test_unit_ready(const CommandState &, Responder &) { return false; }
bool test_unit_ready(const CommandState &, Responder &responder) {
/* "Returns zero status if addressed unit is powered on and ready. */
responder.terminate_command(Target::Responder::Status::Good);
return true;
}
bool rezero_unit(const CommandState &, Responder &) { return false; }
bool request_sense(const CommandState &, Responder &) { return false; }
bool format_unit(const CommandState &, Responder &) { return false; }