From f694620087ddb8c4e7ecc85b85fc352ca660653f Mon Sep 17 00:00:00 2001 From: Thomas Harte Date: Fri, 11 Mar 2022 13:10:44 -0500 Subject: [PATCH] Resolve TODO. --- InstructionSets/x86/Decoder.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/InstructionSets/x86/Decoder.cpp b/InstructionSets/x86/Decoder.cpp index 4e863ebe2..34de2c9ba 100644 --- a/InstructionSets/x86/Decoder.cpp +++ b/InstructionSets/x86/Decoder.cpp @@ -610,7 +610,9 @@ std::pair::InstructionT> Decoder::decode(con Source memreg; - // TODO: can I just eliminate these lookup tables given the deliberate ordering within Source? + // These tables are fairly redundant due to the register ordering within + // Source, but act to improve readability and permit further Source + // reordering in the future. constexpr Source reg_table[8] = { Source::eAX, Source::eCX, Source::eDX, Source::eBX, Source::eSPorAH, Source::eBPorCH, Source::eSIorDH, Source::eDIorBH,