6502/EightBit
1
0
Fork 0
mirror of https://github.com/MoleskiCoder/EightBit.git synced 2025-01-02 18:29:41 +00:00
Code Issues Projects Releases Wiki Activity

Modify virtual default destructor specification to better match core guidelines.

Browse Source 
Signed-off-by: Adrian Conlon <adrian.conlon@gmail.com>
This commit is contained in:
Adrian Conlon 2020-05-03 20:29:18 +01:00
parent 5eedbe1225
commit de800fe9f1
5 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
inc/Chip.h
View File

@ -66,7 +66,7 @@ namespace EightBit {
[[nodiscard]] static constexpr auto promoteNibble(const int value) { return value << 4; }
[[nodiscard]] static constexpr auto demoteNibble(const int value) { return highNibble(value); }
virtual ~Chip() = default;
~Chip() = default;
protected:
Chip() = default;

2
inc/ClockedChip.h
View File

@ -7,7 +7,7 @@
namespace EightBit {
class ClockedChip : public Chip {
public:
virtual ~ClockedChip() = default;
~ClockedChip() = default;
Signal<EventArgs> Ticked;

8
inc/IntelProcessor.h
View File

@ -34,10 +34,10 @@ namespace EightBit {
}
};
virtual ~IntelProcessor() = default;
~IntelProcessor() = default;
[[nodiscard]] const auto& getDecodedOpcode(const size_t i) const noexcept {
return m_decodedOpcodes.at(i);
return m_decodedOpcodes[i];
}
[[nodiscard]] auto& MEMPTR() noexcept { return m_memptr; }
@ -111,13 +111,13 @@ namespace EightBit {
[[nodiscard]] static auto calculateHalfCarryAdd(const uint8_t before, const uint8_t value, const int calculation) noexcept {
static std::array<int, 8> halfCarryTableAdd = { { 0, 0, 1, 0, 1, 0, 1, 1} };
const auto index = buildHalfCarryIndex(before, value, calculation);
return halfCarryTableAdd.at(index & Mask3);
return halfCarryTableAdd[index & Mask3];
}
[[nodiscard]] static auto calculateHalfCarrySub(const uint8_t before, const uint8_t value, const int calculation) noexcept {
std::array<int, 8> halfCarryTableSub = { { 0, 1, 1, 1, 0, 0, 0, 1 } };
const auto index = buildHalfCarryIndex(before, value, calculation);
return halfCarryTableSub.at(index & Mask3);
return halfCarryTableSub[index & Mask3];
}
void handleRESET() override;

2
inc/LittleEndianProcessor.h
View File

@ -8,7 +8,7 @@ namespace EightBit {
class LittleEndianProcessor : public Processor {
public:
virtual ~LittleEndianProcessor() = default;
~LittleEndianProcessor() = default;
register16_t peekWord(register16_t address) final;
void pokeWord(register16_t address, register16_t value) final;

2
inc/Processor.h
View File

@ -15,7 +15,7 @@ namespace EightBit {
// x: sign extend this b-bit number to r
[[nodiscard]] static int8_t signExtend(int b, uint8_t x) noexcept;
virtual ~Processor() = default;
~Processor() = default;
[[nodiscard]] auto& PC() noexcept { return m_pc; }