6502/cc65
1
0
Fork 0
mirror of https://github.com/cc65/cc65.git synced 2025-08-08 06:25:17 +00:00
Code Issues Projects Releases Wiki Activity

Fixed warning on forward declaration of enums.

Browse Source 
Fixed the issue that global static variables put on zeropage were missing optimization.
This commit is contained in:
acqn
2022-08-19 18:48:52 +08:00
parent b8211a2921
commit 3fbefdef45
1 changed files with 12 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/cc65/compile.c
View File

@@ -207,7 +207,7 @@ static void Parse (void)
/* Allow initialization */ /* Allow initialization */
if (CurTok.Tok == TOK_ASSIGN) { if (CurTok.Tok == TOK_ASSIGN) {
/* This is a definition */ /* This is a definition with storage */
if (SymIsDef (Entry)) { if (SymIsDef (Entry)) {
Error ("Global variable '%s' has already been defined", Error ("Global variable '%s' has already been defined",
Entry->Name); Entry->Name);
@@ -251,6 +251,7 @@ static void Parse (void)
ParseInit (Entry->Type); ParseInit (Entry->Type);
} else { } else {
/* This is a declaration */
if (IsTypeVoid (Decl.Type)) { if (IsTypeVoid (Decl.Type)) {
/* We cannot declare variables of type void */ /* We cannot declare variables of type void */
Error ("Illegal type for variable '%s'", Decl.Ident); Error ("Illegal type for variable '%s'", Decl.Ident);
@@ -261,6 +262,15 @@ static void Parse (void)
Error ("Variable '%s' has unknown size", Decl.Ident); Error ("Variable '%s' has unknown size", Decl.Ident);
} }
} else { } else {
/* Check for enum forward declaration.
** Warn about it when extensions are not allowed.
*/
if (Size == 0 && IsTypeEnum (Decl.Type)) {
if (IS_Get (&Standard) != STD_CC65) {
Warning ("ISO C forbids forward references to 'enum' types");
}
}
/* A global (including static) uninitialized variable is /* A global (including static) uninitialized variable is
** only a tentative definition. For example, this is valid: ** only a tentative definition. For example, this is valid:
** int i; ** int i;
@@ -287,17 +297,9 @@ static void Parse (void)
} }
/* Make the symbol zeropage according to the segment address size */ /* Make the symbol zeropage according to the segment address size */
if ((Entry->Flags & SC_EXTERN) != 0) { if ((Entry->Flags & SC_STATIC) != 0) {
if (GetSegAddrSize (GetSegName (CS->CurDSeg)) == ADDR_SIZE_ZP) { if (GetSegAddrSize (GetSegName (CS->CurDSeg)) == ADDR_SIZE_ZP) {
Entry->Flags |= SC_ZEROPAGE; Entry->Flags |= SC_ZEROPAGE;
/* Check for enum forward declaration.
** Warn about it when extensions are not allowed.
*/
if (Size == 0 && IsTypeEnum (Decl.Type)) {
if (IS_Get (&Standard) != STD_CC65) {
Warning ("ISO C forbids forward references to 'enum' types");
}
}
} }
} }