6502/cc65
1
0
Fork 0
mirror of https://github.com/cc65/cc65.git synced 2024-11-16 02:10:52 +00:00
Code Issues Projects Releases Wiki Activity

fix comparing float const vs const

Browse Source
This commit is contained in:
mrdudz 2022-11-12 02:44:01 +01:00
parent 62e211553b
commit 694561e917
3 changed files with 73 additions and 35 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

92
src/cc65/expr.c
View File

@ -2631,37 +2631,75 @@ static void hie_compare (const GenDesc* Ops, /* List of generators */
/* Both operands are numeric constant, remove the generated code */ /* Both operands are numeric constant, remove the generated code */
RemoveCode (&Mark1); RemoveCode (&Mark1);
LOG(("hie_compare (Both operands are numeric constant)\n"));
/* Determine if this is a signed or unsigned compare */ if ((TypeOf (Expr->Type) == CF_FLOAT) || (TypeOf (Expr2.Type) == CF_FLOAT)) {
if (IsClassInt (Expr->Type) && IsSignSigned (Expr->Type) && /* at least one of the operands is a float */
IsClassInt (Expr2.Type) && IsSignSigned (Expr2.Type)) { if ((TypeOf (Expr->Type) == CF_FLOAT) && (TypeOf (Expr2.Type) == CF_FLOAT)) {
/* compare float vs float */
/* Evaluate the result for signed operands */ float Val1 = Expr->V.FVal.V;
signed long Val1 = Expr->IVal; float Val2 = Expr2.V.FVal.V;
signed long Val2 = Expr2.IVal; switch (Tok) {
switch (Tok) { case TOK_EQ: Expr->IVal = (Val1 == Val2); break;
case TOK_EQ: Expr->IVal = (Val1 == Val2); break; case TOK_NE: Expr->IVal = (Val1 != Val2); break;
case TOK_NE: Expr->IVal = (Val1 != Val2); break; case TOK_LT: Expr->IVal = (Val1 < Val2); break;
case TOK_LT: Expr->IVal = (Val1 < Val2); break; case TOK_LE: Expr->IVal = (Val1 <= Val2); break;
case TOK_LE: Expr->IVal = (Val1 <= Val2); break; case TOK_GE: Expr->IVal = (Val1 >= Val2); break;
case TOK_GE: Expr->IVal = (Val1 >= Val2); break; case TOK_GT: Expr->IVal = (Val1 > Val2); break;
case TOK_GT: Expr->IVal = (Val1 > Val2); break; default: Internal ("hie_compare: got token 0x%X\n", Tok);
default: Internal ("hie_compare: got token 0x%X\n", Tok); }
} else {
LOG(("FIXME: comparing float constant with non float constant\n"));
/* FIXME: compare float vs non float */
float Val1 = Expr->V.FVal.V;
signed long Val2 = Expr2.IVal;
if (TypeOf (Expr2.Type) == CF_FLOAT) {
Val1 = Expr2.V.FVal.V;
Val2 = Expr->IVal;
}
switch (Tok) {
case TOK_EQ: Expr->IVal = (Val1 == Val2); break;
case TOK_NE: Expr->IVal = (Val1 != Val2); break;
case TOK_LT: Expr->IVal = (Val1 < Val2); break;
case TOK_LE: Expr->IVal = (Val1 <= Val2); break;
case TOK_GE: Expr->IVal = (Val1 >= Val2); break;
case TOK_GT: Expr->IVal = (Val1 > Val2); break;
default: Internal ("hie_compare: got token 0x%X\n", Tok);
}
} }
} else { } else {
/* Evaluate the result for unsigned operands */ /* Determine if this is a signed or unsigned compare */
unsigned long Val1 = Expr->IVal; if (IsClassInt (Expr->Type) && IsSignSigned (Expr->Type) &&
unsigned long Val2 = Expr2.IVal; IsClassInt (Expr2.Type) && IsSignSigned (Expr2.Type)) {
switch (Tok) {
case TOK_EQ: Expr->IVal = (Val1 == Val2); break; /* Evaluate the result for signed operands */
case TOK_NE: Expr->IVal = (Val1 != Val2); break; signed long Val1 = Expr->IVal;
case TOK_LT: Expr->IVal = (Val1 < Val2); break; signed long Val2 = Expr2.IVal;
case TOK_LE: Expr->IVal = (Val1 <= Val2); break; switch (Tok) {
case TOK_GE: Expr->IVal = (Val1 >= Val2); break; case TOK_EQ: Expr->IVal = (Val1 == Val2); break;
case TOK_GT: Expr->IVal = (Val1 > Val2); break; case TOK_NE: Expr->IVal = (Val1 != Val2); break;
default: Internal ("hie_compare: got token 0x%X\n", Tok); case TOK_LT: Expr->IVal = (Val1 < Val2); break;
case TOK_LE: Expr->IVal = (Val1 <= Val2); break;
case TOK_GE: Expr->IVal = (Val1 >= Val2); break;
case TOK_GT: Expr->IVal = (Val1 > Val2); break;
default: Internal ("hie_compare: got token 0x%X\n", Tok);
}
} else {
/* Evaluate the result for unsigned operands */
unsigned long Val1 = Expr->IVal;
unsigned long Val2 = Expr2.IVal;
switch (Tok) {
case TOK_EQ: Expr->IVal = (Val1 == Val2); break;
case TOK_NE: Expr->IVal = (Val1 != Val2); break;
case TOK_LT: Expr->IVal = (Val1 < Val2); break;
case TOK_LE: Expr->IVal = (Val1 <= Val2); break;
case TOK_GE: Expr->IVal = (Val1 >= Val2); break;
case TOK_GT: Expr->IVal = (Val1 > Val2); break;
default: Internal ("hie_compare: got token 0x%X\n", Tok);
}
} }
} }

0
test/todo/float-cmp-const-const.c → test/val/float-cmp-const-const.c
View File

16
test/val/float-cmp.c
View File

@ -45,27 +45,27 @@ void constconst(void)
// float constant vs float const // float constant vs float const
printf("const vs const\n"); printf("const vs const\n");
// expect("1.5f == 1.6f is", 0, (1.5f == 1.6f)); expect("1.5f == 1.6f is", 0, (1.5f == 1.6f));
// expect("1.6f == 1.5f is", 0, (1.6f == 1.5f)); expect("1.6f == 1.5f is", 0, (1.6f == 1.5f));
expect("1.6f == 1.6f is", 1, (1.6f == 1.6f)); expect("1.6f == 1.6f is", 1, (1.6f == 1.6f));
// expect("1.5f != 1.6f is", 1, (1.5f != 1.6f)); expect("1.5f != 1.6f is", 1, (1.5f != 1.6f));
// expect("1.6f != 1.5f is", 1, (1.6f != 1.5f)); expect("1.6f != 1.5f is", 1, (1.6f != 1.5f));
expect("1.6f != 1.6f is", 0, (1.6f != 1.6f)); expect("1.6f != 1.6f is", 0, (1.6f != 1.6f));
// expect("1.5f < 1.6f is", 1, (1.5f < 1.6f)); expect("1.5f < 1.6f is", 1, (1.5f < 1.6f));
expect("1.6f < 1.5f is", 0, (1.6f < 1.5f)); expect("1.6f < 1.5f is", 0, (1.6f < 1.5f));
expect("1.6f < 1.6f is", 0, (1.6f < 1.6f)); expect("1.6f < 1.6f is", 0, (1.6f < 1.6f));
expect("1.5f > 1.6f is", 0, (1.5f > 1.6f)); expect("1.5f > 1.6f is", 0, (1.5f > 1.6f));
// expect("1.6f > 1.5f is", 1, (1.6f > 1.5f)); expect("1.6f > 1.5f is", 1, (1.6f > 1.5f));
expect("1.6f > 1.6f is", 0, (1.6f > 1.6f)); expect("1.6f > 1.6f is", 0, (1.6f > 1.6f));
expect("1.5f <= 1.6f is", 1, (1.5f <= 1.6f)); expect("1.5f <= 1.6f is", 1, (1.5f <= 1.6f));
// expect("1.6f <= 1.5f is", 0, (1.6f <= 1.5f)); expect("1.6f <= 1.5f is", 0, (1.6f <= 1.5f));
expect("1.6f <= 1.6f is", 1, (1.6f <= 1.6f)); expect("1.6f <= 1.6f is", 1, (1.6f <= 1.6f));
// expect("1.5f >= 1.6f is", 0, (1.5f >= 1.6f)); expect("1.5f >= 1.6f is", 0, (1.5f >= 1.6f));
expect("1.6f >= 1.5f is", 1, (1.6f >= 1.5f)); expect("1.6f >= 1.5f is", 1, (1.6f >= 1.5f));
expect("1.6f >= 1.6f is", 1, (1.6f >= 1.6f)); expect("1.6f >= 1.6f is", 1, (1.6f >= 1.6f));
} }