From f1512af6307734b1ece1dbe86f84716485a94eac Mon Sep 17 00:00:00 2001
From: jespergravgaard <jesper@balmangravgaard.dk>
Date: Sun, 5 Nov 2017 03:10:10 +0100
Subject: [PATCH] Added failing test for inline asm with variable reference
 parameters.

---
 src/main/java/dk/camelot64/kickc/TODO.txt             | 10 +++++-----
 src/main/java/dk/camelot64/kickc/test/TestErrors.java |  4 ++++
 .../java/dk/camelot64/kickc/test/inline-asm-param.kc  | 11 +++++++++++
 src/main/java/dk/camelot64/kickc/test/inline-asm.kc   |  2 +-
 4 files changed, 21 insertions(+), 6 deletions(-)
 create mode 100644 src/main/java/dk/camelot64/kickc/test/inline-asm-param.kc

diff --git a/src/main/java/dk/camelot64/kickc/TODO.txt b/src/main/java/dk/camelot64/kickc/TODO.txt
index f6be7e16f..b2118196a 100644
--- a/src/main/java/dk/camelot64/kickc/TODO.txt
+++ b/src/main/java/dk/camelot64/kickc/TODO.txt
@@ -5,6 +5,7 @@ Known Problems
 - (forrangesymbolic.kc) Range-based for does not recognize symbolic constants. The following gives a ParseTreeConstantEvaluator$NotConstantException - const byte* BITMAP = $2000; for(byte* b : BITMAP..BITMAP+$2000) { *b = 0; }
 - (wordexpr.kc) Expressions based on bytes but resulting in words are erronously infered as bytes - eg. yoffs = yoffs + 40*8;
 - (useuninitialized.kc) Using an uninitialized variable fails in the optimizer phase. It should fail much earlier.
+- (inline-asm-param.kc) Inline ASM does not attempt to handle parameters (variables).
 
 Features
 - Move the main code into a main() function, and disallow code outside functions. The main function per default has no parameters and exits with RTS.
@@ -59,12 +60,7 @@ Arrays / Strings / Inline data
   - Syntax for accessing the low/high byte-array that underlies the word-array. word[$100] plot_x; byte* plot_x_lo = plot_x.lo; plot_x_lo[0] = 0;
 
 - Inline ASM
-  - Add support for inline asm
-    - Syntax asm( "asm...", "asm...", "asm..." ); - aligned with gcc
-    - Better syntax: asm { asm... } - using real ASM syntax inline!
   - Allow inline ASM parameter expansion - eg lda line (where line is a variable)
-  - Support ASM syntax check etc.
-  - Also perform ASM clobber analysis when assigning registers.
   - Allow lda <var> or sta <var> to just perform a register copy if possible.
 
 Assembler Improvements
@@ -182,3 +178,7 @@ Done
 + Inline constants that are only call parameters used once (eg. x0#0 and x0#1 in callconstparam.kc)
 + Ensured that assignment to variables with ALU potential does not affect potential registers through clobbering.
 + (const-identification.kc) Constants are not identified correctly. Some times constant pointers are treated as variables Eg. byte* SCREEN = $0400 is adressed through zero-page even though it can be adressed directly.
++ Add support for inline asm
+  + Syntax: asm { asm... } - using real ASM syntax inline!
++ Support ASM syntax check etc.
++ Also perform ASM clobber analysis when assigning registers.
diff --git a/src/main/java/dk/camelot64/kickc/test/TestErrors.java b/src/main/java/dk/camelot64/kickc/test/TestErrors.java
index 4bdaabd41..1001fc4f1 100644
--- a/src/main/java/dk/camelot64/kickc/test/TestErrors.java
+++ b/src/main/java/dk/camelot64/kickc/test/TestErrors.java
@@ -24,6 +24,10 @@ public class TestErrors extends TestCase {
       helper = new ReferenceHelper("dk/camelot64/kickc/test/ref/");
    }
 
+   public void testInlineAsmParam() throws IOException, URISyntaxException {
+      compileAndCompare("inline-asm-param");
+   }
+
    public void testOverlapAllocation() throws IOException, URISyntaxException {
       compileAndCompare("overlap-allocation");
    }
diff --git a/src/main/java/dk/camelot64/kickc/test/inline-asm-param.kc b/src/main/java/dk/camelot64/kickc/test/inline-asm-param.kc
new file mode 100644
index 000000000..65bb72785
--- /dev/null
+++ b/src/main/java/dk/camelot64/kickc/test/inline-asm-param.kc
@@ -0,0 +1,11 @@
+byte* SCREEN = $0400;
+
+void main() {
+    byte a = 'a';
+    asm {
+        lda {a}
+        sta {SCREEN}
+    };
+    a++;
+
+}
diff --git a/src/main/java/dk/camelot64/kickc/test/inline-asm.kc b/src/main/java/dk/camelot64/kickc/test/inline-asm.kc
index 624026ac5..8b87689e9 100644
--- a/src/main/java/dk/camelot64/kickc/test/inline-asm.kc
+++ b/src/main/java/dk/camelot64/kickc/test/inline-asm.kc
@@ -13,7 +13,7 @@ void main() {
         if((bits & $80) != 0) {
            *sc = '*';
         } else {
-            *sc = '.';
+           *sc = '.';
         }
         sc++;
         bits = bits<<1;