6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-01-16 14:31:59 +00:00
Code Issues Projects Releases Wiki Activity

InstSimplify: Fix a bug when INT_MIN is in a sdiv

Browse Source 
When INT_MIN is the numerator in a sdiv, we would not properly handle
overflow when calculating the bounds of possible values; abs(INT_MIN) is
not a meaningful number.

Instead, check and handle INT_MIN by reasoning that the largest value is
INT_MIN/-2 and the smallest value is INT_MIN.

This fixes PR20199.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@212307 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
David Majnemer 2014-07-04 00:23:39 +00:00
parent 5c58257d39
commit 00428878bb
2 changed files with 20 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lib/Analysis/InstructionSimplify.cpp
View File

@ -1948,9 +1948,15 @@ static Value *SimplifyICmpInst(unsigned Predicate, Value *LHS, Value *RHS,
if (!CI2->isZero()) if (!CI2->isZero())
Upper = NegOne.udiv(CI2->getValue()) + 1; Upper = NegOne.udiv(CI2->getValue()) + 1;
} else if (match(LHS, m_SDiv(m_ConstantInt(CI2), m_Value()))) { } else if (match(LHS, m_SDiv(m_ConstantInt(CI2), m_Value()))) {
// 'sdiv CI2, x' produces [-|CI2|, |CI2|]. if (CI2->isMinSignedValue()) {
Upper = CI2->getValue().abs() + 1; // 'sdiv INT_MIN, x' produces [INT_MIN, INT_MIN / -2].
Lower = (-Upper) + 1; Lower = CI2->getValue();
Upper = Lower.lshr(1) + 1;
} else {
// 'sdiv CI2, x' produces [-|CI2|, |CI2|].
Upper = CI2->getValue().abs() + 1;
Lower = (-Upper) + 1;
}
} else if (match(LHS, m_SDiv(m_Value(), m_ConstantInt(CI2)))) { } else if (match(LHS, m_SDiv(m_Value(), m_ConstantInt(CI2)))) {
// 'sdiv x, CI2' produces [INT_MIN / CI2, INT_MAX / CI2]. // 'sdiv x, CI2' produces [INT_MIN / CI2, INT_MAX / CI2].
APInt IntMin = APInt::getSignedMinValue(Width); APInt IntMin = APInt::getSignedMinValue(Width);

11
test/Transforms/InstSimplify/compare.ll
View File

@ -902,3 +902,14 @@ define i1 @icmp_ne_const(i32 %a) nounwind {
; CHECK-LABEL: @icmp_ne_const ; CHECK-LABEL: @icmp_ne_const
; CHECK-NEXT: ret i1 true ; CHECK-NEXT: ret i1 true
} }
define i1 @icmp_sdiv_int_min(i32 %a) {
%div = sdiv i32 -2147483648, %a
%cmp = icmp ne i32 %div, -1073741824
ret i1 %cmp
; CHECK-LABEL: @icmp_sdiv_int_min
; CHECK-NEXT: [[DIV:%.*]] = sdiv i32 -2147483648, %a
; CHECK-NEXT: [[CMP:%.*]] = icmp ne i32 [[DIV]], -1073741824
; CHECK-NEXT: ret i1 [[CMP]]
}