Fix/strengthen verification of llvm.dbg.declare

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@94195 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Victor Hernandez
2010-01-22 19:06:12 +00:00
parent 29fa5e9886
commit 02d574d7a8

View File

@@ -1581,7 +1581,7 @@ void Verifier::visitIntrinsicFunctionCall(Intrinsic::ID ID, CallInst &CI) {
// If the intrinsic takes MDNode arguments, verify that they are either global // If the intrinsic takes MDNode arguments, verify that they are either global
// or are local to *this* function. // or are local to *this* function.
for (unsigned i = 0, e = CI.getNumOperands(); i != e; ++i) for (unsigned i = 1, e = CI.getNumOperands(); i != e; ++i)
if (MDNode *MD = dyn_cast<MDNode>(CI.getOperand(i))) { if (MDNode *MD = dyn_cast<MDNode>(CI.getOperand(i))) {
if (!MD->isFunctionLocal()) continue; if (!MD->isFunctionLocal()) continue;
SmallPtrSet<MDNode *, 32> Visited; SmallPtrSet<MDNode *, 32> Visited;
@@ -1591,12 +1591,17 @@ void Verifier::visitIntrinsicFunctionCall(Intrinsic::ID ID, CallInst &CI) {
switch (ID) { switch (ID) {
default: default:
break; break;
case Intrinsic::dbg_declare: // llvm.dbg.declare case Intrinsic::dbg_declare: { // llvm.dbg.declare
if (MDNode *MD = dyn_cast<MDNode>(CI.getOperand(1))) Assert1(CI.getOperand(1) && isa<MDNode>(CI.getOperand(1)),
"invalid llvm.dbg.declare intrinsic call 1", &CI);
MDNode *MD = cast<MDNode>(CI.getOperand(1));
Assert1(MD->getNumOperands() == 1,
"invalid llvm.dbg.declare intrinsic call 2", &CI);
if (MD->getOperand(0))
if (Constant *C = dyn_cast<Constant>(MD->getOperand(0))) if (Constant *C = dyn_cast<Constant>(MD->getOperand(0)))
Assert1(C && !isa<ConstantPointerNull>(C), Assert1(C && !isa<ConstantPointerNull>(C),
"invalid llvm.dbg.declare intrinsic call", &CI); "invalid llvm.dbg.declare intrinsic call 3", &CI);
break; } break;
case Intrinsic::memcpy: case Intrinsic::memcpy:
case Intrinsic::memmove: case Intrinsic::memmove:
case Intrinsic::memset: case Intrinsic::memset: