6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-02-25 03:30:37 +00:00
Code Issues Projects Releases Wiki Activity

Fix a bug with .weak_def_can_be_hidden: Mutable variables cannot use it.

Browse Source 
Thanks to John McCall for noticing it.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200977 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Rafael Espindola 2014-02-07 16:21:30 +00:00
parent 12eb44ddab
commit 0732e94378
3 changed files with 48 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lib/CodeGen/AsmPrinter/AsmPrinter.cpp
View File

@ -245,6 +245,18 @@ static bool canBeHidden(const GlobalValue *GV, const MCAsmInfo &MAI) {
if (GV->hasUnnamedAddr())
return true;
// This is only used for MachO, so right now it doesn't really matter how
// we handle alias. Revisit this once the MachO linker implements aliases.
if (isa<GlobalAlias>(GV))
return false;
// If it is a non constant variable, it needs to be uniqued across shared
// objects.
if (const GlobalVariable *Var = dyn_cast<GlobalVariable>(GV)) {
if (!Var->isConstant())
return false;
}
GlobalStatus GS;
if (!GlobalStatus::analyzeGlobal(GV, GS) && !GS.IsCompared)
return true;

24
test/CodeGen/PowerPC/weak_def_can_be_hidden.ll
View File

@ -3,7 +3,7 @@
; RUN: llc -mtriple=powerpc-apple-darwin9 -O0 < %s | FileCheck --check-prefix=CHECK-D89 %s
; RUN: llc -mtriple=powerpc-apple-darwin8 -O0 < %s | FileCheck --check-prefix=CHECK-D89 %s
@v1 = linkonce_odr global i32 32
@v1 = linkonce_odr constant i32 32
; CHECK: .globl _v1
; CHECK: .weak_def_can_be_hidden _v1
@ -15,13 +15,17 @@ define i32 @f1() {
ret i32 %x
}
@v2 = linkonce_odr global i32 32
@v2 = linkonce_odr constant i32 32
; CHECK: .globl _v2
; CHECK: .weak_definition _v2
; CHECK-D89: .globl _v2
; CHECK-D89: .weak_definition _v2
define i32* @f2() {
ret i32* @v2
}
@v3 = linkonce_odr unnamed_addr global i32 32
; CHECK: .globl _v3
; CHECK: .weak_def_can_be_hidden _v3
@ -29,10 +33,18 @@ define i32 @f1() {
; CHECK-D89: .globl _v3
; CHECK-D89: .weak_definition _v3
define i32* @f2() {
ret i32* @v2
}
define i32* @f3() {
ret i32* @v3
}
@v4 = linkonce_odr global i32 32
; CHECK: .globl _v4
; CHECK: .weak_definition _v4
; CHECK-D89: .globl _v4
; CHECK-D89: .weak_definition _v4
define i32 @f4() {
%x = load i32 * @v4
ret i32 %x
}

24
test/CodeGen/X86/weak_def_can_be_hidden.ll
View File

@ -4,7 +4,7 @@
; RUN: llc -mtriple=i686-apple-darwin9 -O0 < %s | FileCheck --check-prefix=CHECK-D89 %s
; RUN: llc -mtriple=i686-apple-darwin8 -O0 < %s | FileCheck --check-prefix=CHECK-D89 %s
@v1 = linkonce_odr global i32 32
@v1 = linkonce_odr constant i32 32
; CHECK: .globl _v1
; CHECK: .weak_def_can_be_hidden _v1
@ -16,13 +16,17 @@ define i32 @f1() {
ret i32 %x
}
@v2 = linkonce_odr global i32 32
@v2 = linkonce_odr constant i32 32
; CHECK: .globl _v2
; CHECK: .weak_definition _v2
; CHECK-D89: .globl _v2
; CHECK-D89: .weak_definition _v2
define i32* @f2() {
ret i32* @v2
}
@v3 = linkonce_odr unnamed_addr global i32 32
; CHECK: .globl _v3
; CHECK: .weak_def_can_be_hidden _v3
@ -30,10 +34,18 @@ define i32 @f1() {
; CHECK-D89: .globl _v3
; CHECK-D89: .weak_definition _v3
define i32* @f2() {
ret i32* @v2
}
define i32* @f3() {
ret i32* @v3
}
@v4 = linkonce_odr global i32 32
; CHECK: .globl _v4
; CHECK: .weak_definition _v4
; CHECK-D89: .globl _v4
; CHECK-D89: .weak_definition _v4
define i32 @f4() {
%x = load i32 * @v4
ret i32 %x
}