6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-08-09 11:25:55 +00:00
Code Issues Projects Releases Wiki Activity

[X86] Don't try to generate direct calls to TLS globals

Browse Source 
The call lowering assumes that if the callee is a global, we want to emit a direct call.
This is correct for regular globals, but not for TLS ones.

Differential Revision: http://reviews.llvm.org/D6862

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@225438 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Michael Kuperstein
2015-01-08 11:50:58 +00:00
parent 1cea749780
commit 0858c28ca8
2 changed files with 21 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
lib/Target/X86/X86ISelLowering.cpp
View File

@@ -3083,10 +3083,11 @@ X86TargetLowering::LowerCall(TargetLowering::CallLoweringInfo &CLI,
// through a register, since the call instruction's 32-bit // through a register, since the call instruction's 32-bit
// pc-relative offset may not be large enough to hold the whole // pc-relative offset may not be large enough to hold the whole
// address. // address.
} else if (GlobalAddressSDNode *G = dyn_cast<GlobalAddressSDNode>(Callee)) { } else if (Callee->getOpcode() == ISD::GlobalAddress) {
// If the callee is a GlobalAddress node (quite common, every direct call // If the callee is a GlobalAddress node (quite common, every direct call
// is) turn it into a TargetGlobalAddress node so that legalize doesn't hack // is) turn it into a TargetGlobalAddress node so that legalize doesn't hack
// it. // it.
GlobalAddressSDNode* G = cast<GlobalAddressSDNode>(Callee);
// We should use extra load for direct calls to dllimported functions in // We should use extra load for direct calls to dllimported functions in
// non-JIT mode. // non-JIT mode.

19
test/CodeGen/X86/pr22103.ll Normal file
View File

@@ -0,0 +1,19 @@
; RUN: llc < %s | FileCheck %s
; Don't try to emit a direct call through a TLS global.
; This fixes PR22103
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu"
@a = external thread_local global i64
; Function Attrs: nounwind
define void @_Z1fv() {
; CHECK-NOT: callq *$a
; CHECK: movq %fs:0, [[RAX:%r..]]
; CHECK-NEXT: addq a@GOTTPOFF(%rip), [[RAX]]
; CHECK-NEXT: callq *%rax
entry:
call void bitcast (i64* @a to void ()*)()
ret void
}