6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2024-12-29 10:32:47 +00:00
Code Issues Projects Releases Wiki Activity

Fix PowerPC/2006-05-12-rlwimi-crash.ll

Browse Source 
Nate, please verify that if InsertMask is 0, rlwimi shouldn't be used.
This fixes the crash and causes no PPC testsuite regressions.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@28243 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Chris Lattner 2006-05-12 16:29:37 +00:00
parent 83cdf40144
commit 0949ed5412
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/Target/PowerPC/PPCISelDAGToDAG.cpp
View File

@ -365,7 +365,7 @@ static bool isRotateAndMask(SDNode *N, unsigned Mask, bool IsShiftMask,
// if the mask doesn't intersect any Indeterminant bits // if the mask doesn't intersect any Indeterminant bits
if (Mask && !(Mask & Indeterminant)) { if (Mask && !(Mask & Indeterminant)) {
SH = Shift; SH = Shift & 31;
// make sure the mask is still a mask (wrap arounds may not be) // make sure the mask is still a mask (wrap arounds may not be)
return isRunOfOnes(Mask, MB, ME); return isRunOfOnes(Mask, MB, ME);
} }
@ -431,7 +431,7 @@ SDNode *PPCDAGToDAGISel::SelectBitfieldInsert(SDNode *N) {
} }
unsigned MB, ME; unsigned MB, ME;
if (isRunOfOnes(InsertMask, MB, ME)) { if (InsertMask && isRunOfOnes(InsertMask, MB, ME)) {
SDOperand Tmp1, Tmp2, Tmp3; SDOperand Tmp1, Tmp2, Tmp3;
bool DisjointMask = (TargetMask ^ InsertMask) == 0xFFFFFFFF; bool DisjointMask = (TargetMask ^ InsertMask) == 0xFFFFFFFF;
@ -454,6 +454,7 @@ SDNode *PPCDAGToDAGISel::SelectBitfieldInsert(SDNode *N) {
Tmp3 = (Op0Opc == ISD::AND && DisjointMask) ? Op0.getOperand(0) : Op0; Tmp3 = (Op0Opc == ISD::AND && DisjointMask) ? Op0.getOperand(0) : Op0;
Select(Tmp1, Tmp3); Select(Tmp1, Tmp3);
Select(Tmp2, Op1); Select(Tmp2, Op1);
SH &= 31;
return CurDAG->getTargetNode(PPC::RLWIMI, MVT::i32, Tmp1, Tmp2, return CurDAG->getTargetNode(PPC::RLWIMI, MVT::i32, Tmp1, Tmp2,
getI32Imm(SH), getI32Imm(MB), getI32Imm(ME)); getI32Imm(SH), getI32Imm(MB), getI32Imm(ME));
} }
@ -1149,7 +1150,7 @@ void PPCDAGToDAGISel::Select(SDOperand &Result, SDOperand Op) {
SDOperand Val; SDOperand Val;
Select(Val, N->getOperand(0).getOperand(0)); Select(Val, N->getOperand(0).getOperand(0));
Result = CurDAG->SelectNodeTo(N, PPC::RLWINM, MVT::i32, Result = CurDAG->SelectNodeTo(N, PPC::RLWINM, MVT::i32,
Val, getI32Imm(SH & 0x1F), getI32Imm(MB), Val, getI32Imm(SH), getI32Imm(MB),
getI32Imm(ME)); getI32Imm(ME));
return; return;
} }