From 0cea42a560e38dafcf697ea054f088f98cb3c4c6 Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Sat, 13 Mar 2004 23:54:27 +0000 Subject: [PATCH] Add some debugging output Fix InstCombine/2004-03-13-InstCombineInfLoop.ll which caused an infinite loop compiling (I think) povray. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@12365 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Transforms/Scalar/InstructionCombining.cpp | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/lib/Transforms/Scalar/InstructionCombining.cpp b/lib/Transforms/Scalar/InstructionCombining.cpp index 866afb48187..93b24878b47 100644 --- a/lib/Transforms/Scalar/InstructionCombining.cpp +++ b/lib/Transforms/Scalar/InstructionCombining.cpp @@ -33,6 +33,7 @@ // //===----------------------------------------------------------------------===// +#define DEBUG_TYPE "instcombine" #include "llvm/Transforms/Scalar.h" #include "llvm/Instructions.h" #include "llvm/Intrinsics.h" @@ -46,6 +47,7 @@ #include "llvm/Support/InstIterator.h" #include "llvm/Support/InstVisitor.h" #include "llvm/Support/CallSite.h" +#include "Support/Debug.h" #include "Support/Statistic.h" #include using namespace llvm; @@ -1551,7 +1553,7 @@ Instruction *InstCombiner::visitSetCondInst(BinaryOperator &I) { if (CastInst *CI = dyn_cast(Op0)) { Value *CastOp0 = CI->getOperand(0); if (CastOp0->getType()->isLosslesslyConvertibleTo(CI->getType()) && - !isa(Op1) && + (isa(Op1) || isa(Op1)) && (I.getOpcode() == Instruction::SetEQ || I.getOpcode() == Instruction::SetNE)) { // We keep moving the cast from the left operand over to the right @@ -2543,6 +2545,9 @@ bool InstCombiner::runOnFunction(Function &F) { ++NumCombined; // Should we replace the old instruction with a new one? if (Result != I) { + DEBUG(std::cerr << "IC: Old = " << *I + << " New = " << *Result); + // Instructions can end up on the worklist more than once. Make sure // we do not process an instruction that has been deleted. removeFromWorkList(I); @@ -2561,6 +2566,8 @@ bool InstCombiner::runOnFunction(Function &F) { // Erase the old instruction. InstParent->getInstList().erase(I); } else { + DEBUG(std::cerr << "IC: MOD = " << *I); + BasicBlock::iterator II = I; // If the instruction was modified, it's possible that it is now dead.