6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-11-06 04:18:00 +00:00
Code Issues Projects Releases Wiki Activity

For 16 and 32-bit multiplies, use the IMUL instruction instead of the MUL instruction.

Browse Source 
This allows us to not force the use of the EAX/AX registers!


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@6830 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Chris Lattner
2003-06-21 17:16:58 +00:00
parent a8cb100706
commit 0f1c461423
2 changed files with 22 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
lib/Target/X86/InstSelectSimple.cpp
View File

@@ -1069,8 +1069,6 @@ void ISel::emitSimpleBinaryOperation(MachineBasicBlock *BB,
/// registers op0Reg and op1Reg, and put the result in DestReg. The type of the /// registers op0Reg and op1Reg, and put the result in DestReg. The type of the
/// result should be given as DestTy. /// result should be given as DestTy.
/// ///
/// FIXME: doMultiply should use one of the two address IMUL instructions!
///
void ISel::doMultiply(MachineBasicBlock *MBB, MachineBasicBlock::iterator &MBBI, void ISel::doMultiply(MachineBasicBlock *MBB, MachineBasicBlock::iterator &MBBI,
unsigned DestReg, const Type *DestTy, unsigned DestReg, const Type *DestTy,
unsigned op0Reg, unsigned op1Reg) { unsigned op0Reg, unsigned op1Reg) {
@@ -1079,28 +1077,20 @@ void ISel::doMultiply(MachineBasicBlock *MBB, MachineBasicBlock::iterator &MBBI,
case cFP: // Floating point multiply case cFP: // Floating point multiply
BMI(BB, MBBI, X86::FpMUL, 2, DestReg).addReg(op0Reg).addReg(op1Reg); BMI(BB, MBBI, X86::FpMUL, 2, DestReg).addReg(op0Reg).addReg(op1Reg);
return; return;
case cInt:
case cShort:
BMI(BB, MBBI, Class == cInt ? X86::IMULr32 : X86::IMULr16, 2, DestReg)
.addReg(op0Reg).addReg(op1Reg);
return;
case cByte:
// Must use the MUL instruction, which forces use of AL...
BMI(MBB, MBBI, X86::MOVrr8, 1, X86::AL).addReg(op0Reg);
BMI(MBB, MBBI, X86::MULr8, 1).addReg(op1Reg);
BMI(MBB, MBBI, X86::MOVrr8, 1, DestReg).addReg(X86::AL);
return;
default: default:
case cLong: assert(0 && "doMultiply cannot operate on LONG values!"); case cLong: assert(0 && "doMultiply cannot operate on LONG values!");
case cByte:
case cShort:
case cInt: // Small integerals, handled below...
break;
} }
static const unsigned Regs[] ={ X86::AL , X86::AX , X86::EAX };
static const unsigned MulOpcode[]={ X86::MULr8 , X86::MULr16 , X86::MULr32 };
static const unsigned MovOpcode[]={ X86::MOVrr8, X86::MOVrr16, X86::MOVrr32 };
unsigned Reg = Regs[Class];
// Emit a MOV to put the first operand into the appropriately-sized
// subreg of EAX.
BMI(MBB, MBBI, MovOpcode[Class], 1, Reg).addReg(op0Reg);
// Emit the appropriate multiply instruction.
BMI(MBB, MBBI, MulOpcode[Class], 1).addReg(op1Reg);
// Emit another MOV to put the result into the destination register.
BMI(MBB, MBBI, MovOpcode[Class], 1, DestReg).addReg(Reg);
} }
/// visitMul - Multiplies are not simple binary operators because they must deal /// visitMul - Multiplies are not simple binary operators because they must deal

32
lib/Target/X86/X86ISelSimple.cpp
View File

@@ -1069,8 +1069,6 @@ void ISel::emitSimpleBinaryOperation(MachineBasicBlock *BB,
/// registers op0Reg and op1Reg, and put the result in DestReg. The type of the /// registers op0Reg and op1Reg, and put the result in DestReg. The type of the
/// result should be given as DestTy. /// result should be given as DestTy.
/// ///
/// FIXME: doMultiply should use one of the two address IMUL instructions!
///
void ISel::doMultiply(MachineBasicBlock *MBB, MachineBasicBlock::iterator &MBBI, void ISel::doMultiply(MachineBasicBlock *MBB, MachineBasicBlock::iterator &MBBI,
unsigned DestReg, const Type *DestTy, unsigned DestReg, const Type *DestTy,
unsigned op0Reg, unsigned op1Reg) { unsigned op0Reg, unsigned op1Reg) {
@@ -1079,28 +1077,20 @@ void ISel::doMultiply(MachineBasicBlock *MBB, MachineBasicBlock::iterator &MBBI,
case cFP: // Floating point multiply case cFP: // Floating point multiply
BMI(BB, MBBI, X86::FpMUL, 2, DestReg).addReg(op0Reg).addReg(op1Reg); BMI(BB, MBBI, X86::FpMUL, 2, DestReg).addReg(op0Reg).addReg(op1Reg);
return; return;
case cInt:
case cShort:
BMI(BB, MBBI, Class == cInt ? X86::IMULr32 : X86::IMULr16, 2, DestReg)
.addReg(op0Reg).addReg(op1Reg);
return;
case cByte:
// Must use the MUL instruction, which forces use of AL...
BMI(MBB, MBBI, X86::MOVrr8, 1, X86::AL).addReg(op0Reg);
BMI(MBB, MBBI, X86::MULr8, 1).addReg(op1Reg);
BMI(MBB, MBBI, X86::MOVrr8, 1, DestReg).addReg(X86::AL);
return;
default: default:
case cLong: assert(0 && "doMultiply cannot operate on LONG values!"); case cLong: assert(0 && "doMultiply cannot operate on LONG values!");
case cByte:
case cShort:
case cInt: // Small integerals, handled below...
break;
} }
static const unsigned Regs[] ={ X86::AL , X86::AX , X86::EAX };
static const unsigned MulOpcode[]={ X86::MULr8 , X86::MULr16 , X86::MULr32 };
static const unsigned MovOpcode[]={ X86::MOVrr8, X86::MOVrr16, X86::MOVrr32 };
unsigned Reg = Regs[Class];
// Emit a MOV to put the first operand into the appropriately-sized
// subreg of EAX.
BMI(MBB, MBBI, MovOpcode[Class], 1, Reg).addReg(op0Reg);
// Emit the appropriate multiply instruction.
BMI(MBB, MBBI, MulOpcode[Class], 1).addReg(op1Reg);
// Emit another MOV to put the result into the destination register.
BMI(MBB, MBBI, MovOpcode[Class], 1, DestReg).addReg(Reg);
} }
/// visitMul - Multiplies are not simple binary operators because they must deal /// visitMul - Multiplies are not simple binary operators because they must deal