diff --git a/lib/Transforms/Scalar/GVNPRE.cpp b/lib/Transforms/Scalar/GVNPRE.cpp index 2a5e0f3fa7f..f3ca084df40 100644 --- a/lib/Transforms/Scalar/GVNPRE.cpp +++ b/lib/Transforms/Scalar/GVNPRE.cpp @@ -73,7 +73,8 @@ namespace { // Helper fuctions // FIXME: eliminate or document these better - void dump(ValueTable& VN, std::set& s); + void dump(ValueTable& VN, std::set& s); + void dump_unique(ValueTable& VN, std::set& s); void clean(ValueTable VN, std::set& set); bool add(ValueTable& VN, std::set& MS, Value* V); Value* find_leader(ValueTable VN, std::set& vals, uint32_t v); @@ -90,7 +91,7 @@ namespace { DominatorTree::DomTreeNode* DI, std::set& currExps, std::set& currPhis, - std::set& currTemps, + std::set& currTemps, std::set& currAvail, std::map > availOut); @@ -250,11 +251,19 @@ void GVNPRE::topo_sort(GVNPRE::ValueTable& VN, } } -void GVNPRE::dump(GVNPRE::ValueTable& VN, std::set& s) { - std::vector sorted; - topo_sort(VN, s, sorted); + +void GVNPRE::dump(GVNPRE::ValueTable& VN, std::set& s) { DOUT << "{ "; - for (std::vector::iterator I = sorted.begin(), E = sorted.end(); + for (std::set::iterator I = s.begin(), E = s.end(); + I != E; ++I) { + DEBUG((*I)->dump()); + } + DOUT << "}\n\n"; +} + +void GVNPRE::dump_unique(GVNPRE::ValueTable& VN, std::set& s) { + DOUT << "{ "; + for (std::set::iterator I = s.begin(), E = s.end(); I != E; ++I) { DEBUG((*I)->dump()); } @@ -265,7 +274,7 @@ void GVNPRE::CalculateAvailOut(GVNPRE::ValueTable& VN, std::set& DominatorTree::DomTreeNode* DI, std::set& currExps, std::set& currPhis, - std::set& currTemps, + std::set& currTemps, std::set& currAvail, std::map > availOut) { @@ -297,7 +306,7 @@ void GVNPRE::CalculateAvailOut(GVNPRE::ValueTable& VN, std::set& currExps.insert(BO); currTemps.insert(BO); - + // Handle unsupported ops } else if (!BI->isTerminator()){ add(VN, MS, BI); @@ -315,7 +324,7 @@ bool GVNPRE::runOnFunction(Function &F) { std::map > generatedExpressions; std::map > generatedPhis; - std::map > generatedTemporaries; + std::map > generatedTemporaries; std::map > availableOut; std::map > anticipatedIn; @@ -330,7 +339,7 @@ bool GVNPRE::runOnFunction(Function &F) { // Get the sets to update for this block std::set& currExps = generatedExpressions[DI->getBlock()]; std::set& currPhis = generatedPhis[DI->getBlock()]; - std::set& currTemps = generatedTemporaries[DI->getBlock()]; + std::set& currTemps = generatedTemporaries[DI->getBlock()]; std::set& currAvail = availableOut[DI->getBlock()]; CalculateAvailOut(VN, maximalSet, *DI, currExps, currPhis, @@ -423,15 +432,15 @@ bool GVNPRE::runOnFunction(Function &F) { DOUT << "\n"; DOUT << "EXP_GEN: "; - dump(VN, generatedExpressions[I]); + dump_unique(VN, generatedExpressions[I]); DOUT << "\n"; DOUT << "ANTIC_IN: "; - dump(VN, anticipatedIn[I]); + dump_unique(VN, anticipatedIn[I]); DOUT << "\n"; DOUT << "AVAIL_OUT: "; - dump(VN, availableOut[I]); + dump_unique(VN, availableOut[I]); DOUT << "\n"; }