6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-08-14 15:28:20 +00:00
Code Issues Projects Releases Wiki Activity

Use isa instead of dyn_cast when the result is only converted to bool.

Browse Source 
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@78685 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Dan Gohman
2009-08-11 17:20:16 +00:00
parent a44fa8333e
commit 104eac156e
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
include/llvm/Support/IRBuilder.h
View File

@@ -363,7 +363,7 @@ public:
// Every index must be constant. // Every index must be constant.
InputIterator i; InputIterator i;
for (i = IdxBegin; i < IdxEnd; ++i) { for (i = IdxBegin; i < IdxEnd; ++i) {
if (!dyn_cast<Constant>(*i)) if (!isa<Constant>(*i))
break; break;
} }
if (i == IdxEnd) if (i == IdxEnd)

4
lib/Analysis/IPA/Andersens.cpp
View File

@@ -997,7 +997,7 @@ bool Andersens::AnalyzeUsesOfFunction(Value *V) {
if (!isa<PointerType>(V->getType())) return true; if (!isa<PointerType>(V->getType())) return true;
for (Value::use_iterator UI = V->use_begin(), E = V->use_end(); UI != E; ++UI) for (Value::use_iterator UI = V->use_begin(), E = V->use_end(); UI != E; ++UI)
if (dyn_cast<LoadInst>(*UI)) { if (isa<LoadInst>(*UI)) {
return false; return false;
} else if (StoreInst *SI = dyn_cast<StoreInst>(*UI)) { } else if (StoreInst *SI = dyn_cast<StoreInst>(*UI)) {
if (V == SI->getOperand(1)) { if (V == SI->getOperand(1)) {
@@ -1028,7 +1028,7 @@ bool Andersens::AnalyzeUsesOfFunction(Value *V) {
} else if (ICmpInst *ICI = dyn_cast<ICmpInst>(*UI)) { } else if (ICmpInst *ICI = dyn_cast<ICmpInst>(*UI)) {
if (!isa<ConstantPointerNull>(ICI->getOperand(1))) if (!isa<ConstantPointerNull>(ICI->getOperand(1)))
return true; // Allow comparison against null. return true; // Allow comparison against null.
} else if (dyn_cast<FreeInst>(*UI)) { } else if (isa<FreeInst>(*UI)) {
return false; return false;
} else { } else {
return true; return true;