From 10c3e128efc9a2efd28414400827fa8b457def4d Mon Sep 17 00:00:00 2001 From: Rafael Espindola Date: Tue, 24 May 2011 02:50:20 +0000 Subject: [PATCH] Fix the defaults for .eh_frame. We were marking it as writable. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@131951 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/CodeGen/TargetLoweringObjectFileImpl.cpp | 4 ++-- test/CodeGen/X86/eh_frame.ll | 5 +++++ 2 files changed, 7 insertions(+), 2 deletions(-) create mode 100644 test/CodeGen/X86/eh_frame.ll diff --git a/lib/CodeGen/TargetLoweringObjectFileImpl.cpp b/lib/CodeGen/TargetLoweringObjectFileImpl.cpp index cb337d84dba..ff88b6f2e99 100644 --- a/lib/CodeGen/TargetLoweringObjectFileImpl.cpp +++ b/lib/CodeGen/TargetLoweringObjectFileImpl.cpp @@ -255,7 +255,7 @@ getELFKindForNamedSection(StringRef Name, SectionKind K) { return SectionKind::getThreadBSS(); if (Name == ".eh_frame") - return SectionKind::getDataRel(); + return SectionKind::getReadOnlyWithRel(); return K; } @@ -289,7 +289,7 @@ getELFSectionFlags(SectionKind K) { if (K.isText()) Flags |= ELF::SHF_EXECINSTR; - if (K.isWriteable()) + if (K.isWriteable() && !K.isReadOnlyWithRel()) Flags |= ELF::SHF_WRITE; if (K.isThreadLocal()) diff --git a/test/CodeGen/X86/eh_frame.ll b/test/CodeGen/X86/eh_frame.ll new file mode 100644 index 00000000000..e8d3c87d41b --- /dev/null +++ b/test/CodeGen/X86/eh_frame.ll @@ -0,0 +1,5 @@ +; RUN: llc < %s -mtriple x86_64-unknown-linux-gnu | FileCheck %s + +@__FRAME_END__ = constant [1 x i32] zeroinitializer, section ".eh_frame" + +; CHECK: .section .eh_frame,"a",@progbits