diff --git a/lib/Target/X86/X86ISelLowering.cpp b/lib/Target/X86/X86ISelLowering.cpp index 431101b6eb7..27b2d0bb942 100644 --- a/lib/Target/X86/X86ISelLowering.cpp +++ b/lib/Target/X86/X86ISelLowering.cpp @@ -9544,6 +9544,11 @@ SDValue X86TargetLowering::EmitTest(SDValue Op, unsigned X86CC, SelectionDAG &DAG) const { SDLoc dl(Op); + if (Op.getValueType() == MVT::i1) + // KORTEST instruction should be selected + return DAG.getNode(X86ISD::CMP, dl, MVT::i32, Op, + DAG.getConstant(0, Op.getValueType())); + // CF and OF aren't always set the way we want. Determine which // of these we need. bool NeedCF = false; @@ -9560,15 +9565,14 @@ SDValue X86TargetLowering::EmitTest(SDValue Op, unsigned X86CC, NeedOF = true; break; } - // See if we can use the EFLAGS value from the operand instead of // doing a separate TEST. TEST always sets OF and CF to 0, so unless // we prove that the arithmetic won't overflow, we can't use OF or CF. if (Op.getResNo() != 0 || NeedOF || NeedCF) { // Emit a CMP with 0, which is the TEST pattern. - if (Op.getValueType() == MVT::i1) - return DAG.getNode(X86ISD::CMP, dl, MVT::i1, Op, - DAG.getConstant(0, MVT::i1)); + //if (Op.getValueType() == MVT::i1) + // return DAG.getNode(X86ISD::CMP, dl, MVT::i1, Op, + // DAG.getConstant(0, MVT::i1)); return DAG.getNode(X86ISD::CMP, dl, MVT::i32, Op, DAG.getConstant(0, Op.getValueType())); } @@ -9762,10 +9766,10 @@ SDValue X86TargetLowering::EmitCmp(SDValue Op0, SDValue Op1, unsigned X86CC, return EmitTest(Op0, X86CC, DAG); if (Op0.getValueType() == MVT::i1) { + // invert the value Op0 = DAG.getNode(ISD::XOR, dl, MVT::i1, Op0, DAG.getConstant(-1, MVT::i1)); - return DAG.getNode(X86ISD::CMP, dl, MVT::i1, Op0, - DAG.getConstant(0, MVT::i1)); + return EmitTest(Op0, X86CC, DAG); } } diff --git a/test/CodeGen/X86/avx512-cmp.ll b/test/CodeGen/X86/avx512-cmp.ll index 5bc02070acf..3515529c89c 100644 --- a/test/CodeGen/X86/avx512-cmp.ll +++ b/test/CodeGen/X86/avx512-cmp.ll @@ -96,3 +96,12 @@ entry: ret i32 %or } +define i32 @test8(i32 %a1, i32 %a2, i32 %a3) { + %tmp1 = icmp eq i32 %a1, -1 + %tmp2 = icmp eq i32 %a2, -2147483648 + %tmp3 = and i1 %tmp1, %tmp2 + %tmp4 = icmp eq i32 %a3, 0 + %tmp5 = or i1 %tmp3, %tmp4 + %res = select i1 %tmp5, i32 1, i32 %a3 + ret i32 %res + } \ No newline at end of file