From 17fb34bf8cd10a798c9206eeef3bff151b4d3688 Mon Sep 17 00:00:00 2001 From: Tanya Lattner Date: Mon, 24 May 2004 07:14:35 +0000 Subject: [PATCH] Moved MachineBasicBlock deconstructor to cpp file and removed it from LeakDetector to fix memory leak bug. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@13718 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/llvm/CodeGen/MachineBasicBlock.h | 3 ++- include/llvm/CodeGen/MachineFunction.h | 8 ++++---- lib/CodeGen/MachineBasicBlock.cpp | 10 ++++++++-- lib/CodeGen/MachineFunction.cpp | 6 +++--- 4 files changed, 17 insertions(+), 10 deletions(-) diff --git a/include/llvm/CodeGen/MachineBasicBlock.h b/include/llvm/CodeGen/MachineBasicBlock.h index 4dfda90ae80..3dee00da319 100644 --- a/include/llvm/CodeGen/MachineBasicBlock.h +++ b/include/llvm/CodeGen/MachineBasicBlock.h @@ -71,7 +71,8 @@ public: Number(-1), Parent(0) { Insts.parent = this; } - ~MachineBasicBlock() {} + + ~MachineBasicBlock(); /// getBasicBlock - Return the LLVM basic block that this instance /// corresponded to originally. diff --git a/include/llvm/CodeGen/MachineFunction.h b/include/llvm/CodeGen/MachineFunction.h index dcec822f8e9..e1c19865fa4 100644 --- a/include/llvm/CodeGen/MachineFunction.h +++ b/include/llvm/CodeGen/MachineFunction.h @@ -28,10 +28,10 @@ template <> class ilist_traits { // this is only set by the MachineFunction owning the ilist friend class MachineFunction; - MachineFunction* parent; + MachineFunction* Parent; public: - ilist_traits() : parent(0) { } + ilist_traits() : Parent(0) { } static MachineBasicBlock* getPrev(MachineBasicBlock* N) { return N->Prev; } static MachineBasicBlock* getNext(MachineBasicBlock* N) { return N->Next; } @@ -68,7 +68,7 @@ class MachineFunction : private Annotation { const TargetMachine &Target; // List of machine basic blocks in function - iplist BasicBlocks; + ilist BasicBlocks; // Keeping track of mapping from SSA values to registers SSARegMap *SSARegMapping; @@ -145,7 +145,7 @@ public: static MachineFunction& get(const Function *F); // Provide accessors for the MachineBasicBlock list... - typedef iplist BasicBlockListType; + typedef ilist BasicBlockListType; typedef BasicBlockListType::iterator iterator; typedef BasicBlockListType::const_iterator const_iterator; typedef std::reverse_iterator const_reverse_iterator; diff --git a/lib/CodeGen/MachineBasicBlock.cpp b/lib/CodeGen/MachineBasicBlock.cpp index c0b144d26c3..c72b247d8a4 100644 --- a/lib/CodeGen/MachineBasicBlock.cpp +++ b/lib/CodeGen/MachineBasicBlock.cpp @@ -20,14 +20,20 @@ #include "Support/LeakDetector.h" using namespace llvm; +MachineBasicBlock::~MachineBasicBlock() { + LeakDetector::removeGarbageObject(this); +} + + + // MBBs start out as #-1. When a MBB is added to a MachineFunction, it // gets the next available unique MBB number. If it is removed from a // MachineFunction, it goes back to being #-1. void ilist_traits::addNodeToList (MachineBasicBlock* N) { assert(N->Parent == 0 && "machine instruction already in a basic block"); - N->Parent = parent; - N->Number = parent->getNextMBBNumber(); + N->Parent = Parent; + N->Number = Parent->getNextMBBNumber(); LeakDetector::removeGarbageObject(N); diff --git a/lib/CodeGen/MachineFunction.cpp b/lib/CodeGen/MachineFunction.cpp index a3e9211f5c3..54149c3281f 100644 --- a/lib/CodeGen/MachineFunction.cpp +++ b/lib/CodeGen/MachineFunction.cpp @@ -98,9 +98,9 @@ void ilist_traits::transferNodesFromList( ilist_iterator first, ilist_iterator last) { - if (parent != toList.parent) + if (Parent != toList.Parent) for (; first != last; ++first) - first->Parent = toList.parent; + first->Parent = toList.Parent; } MachineFunction::MachineFunction(const Function *F, @@ -110,7 +110,7 @@ MachineFunction::MachineFunction(const Function *F, MFInfo = new MachineFunctionInfo(*this); FrameInfo = new MachineFrameInfo(); ConstantPool = new MachineConstantPool(); - BasicBlocks.parent = this; + BasicBlocks.Parent = this; } MachineFunction::~MachineFunction() {