6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2024-12-28 04:33:05 +00:00
Code Issues Projects Releases Wiki Activity

Fix inappropriate use of anonymous namespaces in unittests.

Browse Source 
The TEST_F macros actually declare *subclasses* of the test fixtures.
Even if they didn't we don't want them to declare external functions.
The entire unit test, including both the fixture class and the fixture
test cases should be wrapped in the anonymous namespace.

This issue was caught by the new '-Winternal-linkage-in-inline' warning.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@158798 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Chandler Carruth 2012-06-20 08:39:27 +00:00
parent 65d36f0367
commit 1880e2d344
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
unittests/Support/IRBuilderTest.cpp
View File

@ -20,6 +20,7 @@
using namespace llvm;
namespace {
class IRBuilderTest : public testing::Test {
protected:
virtual void SetUp() {
@ -38,7 +39,6 @@ protected:
OwningPtr<Module> M;
BasicBlock *BB;
};
}
TEST_F(IRBuilderTest, Lifetime) {
IRBuilder<> Builder(BB);
@ -70,3 +70,5 @@ TEST_F(IRBuilderTest, Lifetime) {
ASSERT_TRUE(II_End1 != NULL);
EXPECT_EQ(II_End1->getIntrinsicID(), Intrinsic::lifetime_end);
}
}

4
unittests/Transforms/Utils/Cloning.cpp
View File

@ -18,6 +18,7 @@
using namespace llvm;
namespace {
class CloneInstruction : public ::testing::Test {
protected:
virtual void SetUp() {
@ -48,7 +49,6 @@ protected:
LLVMContext context;
Value *V;
};
}
TEST_F(CloneInstruction, OverflowBits) {
V = new Argument(Type::getInt32Ty(context));
@ -142,3 +142,5 @@ TEST_F(CloneInstruction, Exact) {
SDiv->setIsExact(true);
EXPECT_TRUE(this->clone(SDiv)->isExact());
}
}