6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-06-26 07:24:25 +00:00
Code Issues Projects Releases Wiki Activity

When checking for signed multiplication overflow, watch out for INT_MIN and -1.

Browse Source 
This fixes PR9845.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@131919 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Dan Gohman
2011-05-23 21:07:39 +00:00
parent 95ae09afde
commit 1b58d4536a
2 changed files with 20 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/Transforms/Scalar/LoopStrengthReduce.cpp
View File

@ -2522,6 +2522,8 @@ void LSRInstance::GenerateICmpZeroScales(LSRUse &LU, unsigned LUIdx,
// Check that multiplying with the unfolded offset doesn't overflow. // Check that multiplying with the unfolded offset doesn't overflow.
if (F.UnfoldedOffset != 0) { if (F.UnfoldedOffset != 0) {
if (F.UnfoldedOffset == INT64_MIN && Factor == -1)
continue;
F.UnfoldedOffset = (uint64_t)F.UnfoldedOffset * Factor; F.UnfoldedOffset = (uint64_t)F.UnfoldedOffset * Factor;
if (F.UnfoldedOffset / Factor != Base.UnfoldedOffset) if (F.UnfoldedOffset / Factor != Base.UnfoldedOffset)
continue; continue;

18
test/CodeGen/X86/lsr-overflow.ll
View File

@ -25,3 +25,21 @@ __ABContainsLabel.exit:
%cmp = icmp eq i64 %indvar, 9223372036854775807 %cmp = icmp eq i64 %indvar, 9223372036854775807
ret i1 %cmp ret i1 %cmp
} }
define void @func_37() noreturn nounwind readonly {
entry:
br label %for.body
for.body: ; preds = %for.inc8, %entry
%indvar = phi i64 [ 0, %entry ], [ %indvar.next, %for.inc8 ]
%sub.i = add i64 undef, %indvar
%cmp.i = icmp eq i64 %sub.i, -9223372036854775808
br i1 undef, label %for.inc8, label %for.cond4
for.cond4: ; preds = %for.cond4, %for.body
br label %for.cond4
for.inc8: ; preds = %for.body
%indvar.next = add i64 %indvar, 1
br label %for.body
}