From 1bdc6c4519d9ad254b20534a1664f9d2809a95f1 Mon Sep 17 00:00:00 2001 From: David Blaikie Date: Mon, 15 Sep 2014 22:41:25 +0000 Subject: [PATCH] DebugInfo: Add comment describing the need to disable address pool usage in skeleton units. Post commit review from Eric Christopher. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217842 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/CodeGen/AsmPrinter/DwarfUnit.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lib/CodeGen/AsmPrinter/DwarfUnit.cpp b/lib/CodeGen/AsmPrinter/DwarfUnit.cpp index 4206ffd5535..4cd32f8668e 100644 --- a/lib/CodeGen/AsmPrinter/DwarfUnit.cpp +++ b/lib/CodeGen/AsmPrinter/DwarfUnit.cpp @@ -286,6 +286,11 @@ void DwarfUnit::addSectionOffset(DIE &Die, dwarf::Attribute Attribute, void DwarfCompileUnit::addLabelAddress(DIE &Die, dwarf::Attribute Attribute, const MCSymbol *Label) { + // Don't use the address pool in non-fission or in the skeleton unit itself. + // FIXME: Once GDB supports this, it's probably worthwhile using the address + // pool from the skeleton - maybe even in non-fission (possibly fewer + // relocations by sharing them in the pool, but we have other ideas about how + // to reduce the number of relocations as well/instead). if (!DD->useSplitDwarf() || !Skeleton) return addLocalLabelAddress(Die, Attribute, Label);