6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-08-09 11:25:55 +00:00
Code Issues Projects Releases Wiki Activity

Fix GlobalOpt/2006-11-01-ShrinkGlobalPhiCrash.ll and McGill/chomp

Browse Source 
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@31352 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Chris Lattner
2006-11-01 18:03:33 +00:00
parent 22c8648b8a
commit 25de4e5c21
1 changed files with 14 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
lib/Transforms/IPO/GlobalOpt.cpp
View File

@@ -104,17 +104,20 @@ struct GlobalStatus {
/// ever stored to this global, keep track of what value it is. /// ever stored to this global, keep track of what value it is.
Value *StoredOnceValue; Value *StoredOnceValue;
// AccessingFunction/HasMultipleAccessingFunctions - These start out /// AccessingFunction/HasMultipleAccessingFunctions - These start out
// null/false. When the first accessing function is noticed, it is recorded. /// null/false. When the first accessing function is noticed, it is recorded.
// When a second different accessing function is noticed, /// When a second different accessing function is noticed,
// HasMultipleAccessingFunctions is set to true. /// HasMultipleAccessingFunctions is set to true.
Function *AccessingFunction; Function *AccessingFunction;
bool HasMultipleAccessingFunctions; bool HasMultipleAccessingFunctions;
// HasNonInstructionUser - Set to true if this global has a user that is not /// HasNonInstructionUser - Set to true if this global has a user that is not
// an instruction (e.g. a constant expr or GV initializer). /// an instruction (e.g. a constant expr or GV initializer).
bool HasNonInstructionUser; bool HasNonInstructionUser;
/// HasPHIUser - Set to true if this global has a user that is a PHI node.
bool HasPHIUser;
/// isNotSuitableForSRA - Keep track of whether any SRA preventing users of /// isNotSuitableForSRA - Keep track of whether any SRA preventing users of
/// the global exist. Such users include GEP instruction with variable /// the global exist. Such users include GEP instruction with variable
/// indexes, and non-gep/load/store users like constant expr casts. /// indexes, and non-gep/load/store users like constant expr casts.
@@ -122,7 +125,8 @@ struct GlobalStatus {
GlobalStatus() : isLoaded(false), StoredType(NotStored), StoredOnceValue(0), GlobalStatus() : isLoaded(false), StoredType(NotStored), StoredOnceValue(0),
AccessingFunction(0), HasMultipleAccessingFunctions(false), AccessingFunction(0), HasMultipleAccessingFunctions(false),
HasNonInstructionUser(false), isNotSuitableForSRA(false) {} HasNonInstructionUser(false), HasPHIUser(false),
isNotSuitableForSRA(false) {}
}; };
@@ -238,6 +242,7 @@ static bool AnalyzeGlobal(Value *V, GlobalStatus &GS,
if (PHIUsers.insert(PN).second) // Not already visited. if (PHIUsers.insert(PN).second) // Not already visited.
if (AnalyzeGlobal(I, GS, PHIUsers)) return true; if (AnalyzeGlobal(I, GS, PHIUsers)) return true;
GS.isNotSuitableForSRA = true; GS.isNotSuitableForSRA = true;
GS.HasPHIUser = true;
} else if (isa<SetCondInst>(I)) { } else if (isa<SetCondInst>(I)) {
GS.isNotSuitableForSRA = true; GS.isNotSuitableForSRA = true;
} else if (isa<MemCpyInst>(I) || isa<MemMoveInst>(I)) { } else if (isa<MemCpyInst>(I) || isa<MemMoveInst>(I)) {
@@ -1321,7 +1326,8 @@ bool GlobalOpt::ProcessInternalGlobal(GlobalVariable *GV,
// boolean. // boolean.
if (Constant *SOVConstant = dyn_cast<Constant>(GS.StoredOnceValue)) if (Constant *SOVConstant = dyn_cast<Constant>(GS.StoredOnceValue))
if (GV->getType()->getElementType() != Type::BoolTy && if (GV->getType()->getElementType() != Type::BoolTy &&
!GV->getType()->getElementType()->isFloatingPoint()) { !GV->getType()->getElementType()->isFloatingPoint() &&
!GS.HasPHIUser) {
DEBUG(std::cerr << " *** SHRINKING TO BOOL: " << *GV); DEBUG(std::cerr << " *** SHRINKING TO BOOL: " << *GV);
ShrinkGlobalToBoolean(GV, SOVConstant); ShrinkGlobalToBoolean(GV, SOVConstant);
++NumShrunkToBool; ++NumShrunkToBool;