From 26668d093e4668a28f377c521c280454dc1b35ab Mon Sep 17 00:00:00 2001
From: Rafael Espindola <rafael.espindola@gmail.com>
Date: Tue, 6 May 2014 22:44:30 +0000
Subject: [PATCH] Special case aliases in GlobalValue::getSection.

This is similar to the getAlignment patch, but is done just for
completeness. It looks like we never call getSection on an alias. All the
tests still pass if the if is replaced with an assert.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@208139 91177308-0d34-0410-b5e6-96231b3b80d8
---
 include/llvm/IR/GlobalValue.h | 4 ++--
 lib/IR/Globals.cpp            | 6 ++++++
 lib/IR/Verifier.cpp           | 1 -
 3 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/include/llvm/IR/GlobalValue.h b/include/llvm/IR/GlobalValue.h
index 5d0e3791e85..31cd31d7413 100644
--- a/include/llvm/IR/GlobalValue.h
+++ b/include/llvm/IR/GlobalValue.h
@@ -106,8 +106,8 @@ public:
   }
   void setDLLStorageClass(DLLStorageClassTypes C) { DllStorageClass = C; }
 
-  bool hasSection() const { return !Section.empty(); }
-  const std::string &getSection() const { return Section; }
+  bool hasSection() const { return !getSection().empty(); }
+  const std::string &getSection() const;
   void setSection(StringRef S);
 
   /// getType - Global values are always pointers.
diff --git a/lib/IR/Globals.cpp b/lib/IR/Globals.cpp
index 2265e4c2b72..f97602015f1 100644
--- a/lib/IR/Globals.cpp
+++ b/lib/IR/Globals.cpp
@@ -80,6 +80,12 @@ void GlobalValue::setAlignment(unsigned Align) {
   assert(getAlignment() == Align && "Alignment representation error!");
 }
 
+const std::string &GlobalValue::getSection() const {
+  if (auto *GA = dyn_cast<GlobalAlias>(this))
+    return GA->getAliasedGlobal()->getSection();
+  return Section;
+}
+
 void GlobalValue::setSection(StringRef S) {
   assert(!isa<GlobalAlias>(this) && "GlobalAlias should not have a section!");
   Section = S;
diff --git a/lib/IR/Verifier.cpp b/lib/IR/Verifier.cpp
index bc378aed16b..083f7b5255e 100644
--- a/lib/IR/Verifier.cpp
+++ b/lib/IR/Verifier.cpp
@@ -476,7 +476,6 @@ void Verifier::visitGlobalAlias(const GlobalAlias &GA) {
   Assert1(GA.getType() == GA.getAliasee()->getType(),
           "Alias and aliasee types should match!", &GA);
   Assert1(!GA.hasUnnamedAddr(), "Alias cannot have unnamed_addr!", &GA);
-  Assert1(!GA.hasSection(), "Alias cannot have a section!", &GA);
 
   const Constant *Aliasee = GA.getAliasee();
   const GlobalValue *GV = dyn_cast<GlobalValue>(Aliasee);