6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-06-23 17:24:48 +00:00
Code Issues Projects Releases Wiki Activity

add a check that allows the SRoA pass to avoid breaking programs, even if their

Browse Source 
behavior is technically undefined


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@6438 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Chris Lattner
2003-05-30 18:09:57 +00:00
parent 9b03633265
commit 26d2ca1d13
1 changed files with 33 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
lib/Transforms/Scalar/ScalarReplAggregates.cpp
View File

@ -23,6 +23,7 @@ namespace {
bool runOnFunction(Function &F); bool runOnFunction(Function &F);
private: private:
bool isSafeStructElementUse(Value *Ptr);
bool isSafeArrayElementUse(Value *Ptr); bool isSafeArrayElementUse(Value *Ptr);
bool isSafeUseOfAllocation(Instruction *User); bool isSafeUseOfAllocation(Instruction *User);
bool isSafeStructAllocaToPromote(AllocationInst *AI); bool isSafeStructAllocaToPromote(AllocationInst *AI);
@ -166,6 +167,31 @@ bool SROA::isSafeUseOfAllocation(Instruction *User) {
return true; return true;
} }
/// isSafeStructElementUse - It is illegal in C to take the address of a
/// structure sub-element, and then use pointer arithmetic to access other
/// elements of the struct. Despite the fact that this is illegal, some
/// programs do this, so do at least a simple check to try to avoid breaking
/// broken programs if possible.
///
bool SROA::isSafeStructElementUse(Value *Ptr) {
for (Value::use_iterator I = Ptr->use_begin(), E = Ptr->use_end();
I != E; ++I)
if (GetElementPtrInst *GEP = dyn_cast<GetElementPtrInst>(*I)) {
if (GEP->getNumOperands() > 1) {
if (!isa<Constant>(GEP->getOperand(1)) ||
!cast<Constant>(GEP->getOperand(1))->isNullValue()) {
std::cerr << "WARNING: Undefined behavior found: " << *GEP
<< " ... uses pointer arithmetic to access other struct "
<< "elements!\n";
return false;
return false; // Using pointer arithmetic to navigate the array...
}
}
}
return true;
}
/// isSafeArrayElementUse - Check to see if this use is an allowed use for a /// isSafeArrayElementUse - Check to see if this use is an allowed use for a
/// getelementptr instruction of an array aggregate allocation. /// getelementptr instruction of an array aggregate allocation.
@ -210,12 +236,18 @@ bool SROA::isSafeStructAllocaToPromote(AllocationInst *AI) {
// the users are safe to transform. // the users are safe to transform.
// //
for (Value::use_iterator I = AI->use_begin(), E = AI->use_end(); for (Value::use_iterator I = AI->use_begin(), E = AI->use_end();
I != E; ++I) I != E; ++I) {
if (!isSafeUseOfAllocation(cast<Instruction>(*I))) { if (!isSafeUseOfAllocation(cast<Instruction>(*I))) {
DEBUG(std::cerr << "Cannot transform: " << *AI << " due to user: " DEBUG(std::cerr << "Cannot transform: " << *AI << " due to user: "
<< *I); << *I);
return false; return false;
} }
// Pedantic check to avoid breaking broken programs...
if (GetElementPtrInst *GEPI = dyn_cast<GetElementPtrInst>(*I))
if (GEPI->getNumOperands() == 3 && !isSafeStructElementUse(GEPI))
return false;
}
return true; return true;
} }