diff --git a/include/llvm/Support/FileSystem.h b/include/llvm/Support/FileSystem.h index 6b3b126ea03..c9ecc30efbf 100644 --- a/include/llvm/Support/FileSystem.h +++ b/include/llvm/Support/FileSystem.h @@ -33,6 +33,7 @@ #include "llvm/ADT/Twine.h" #include "llvm/Support/DataTypes.h" #include "llvm/Support/ErrorHandling.h" +#include "llvm/Support/TimeValue.h" #include "llvm/Support/system_error.h" #include #include @@ -151,6 +152,7 @@ class file_status #if defined(LLVM_ON_UNIX) dev_t fs_st_dev; ino_t fs_st_ino; + time_t fs_st_mtime; #elif defined (LLVM_ON_WIN32) uint32_t LastWriteTimeHigh; uint32_t LastWriteTimeLow; @@ -177,6 +179,7 @@ public: // setters void type(file_type v) { Type = v; } void permissions(perms p) { Perms = p; } + TimeValue getLastModificationTime(); }; /// file_magic - An "enum class" enumeration of file types based on magic (the first diff --git a/lib/Support/Unix/PathV2.inc b/lib/Support/Unix/PathV2.inc index 39b33123de8..4b922da7186 100644 --- a/lib/Support/Unix/PathV2.inc +++ b/lib/Support/Unix/PathV2.inc @@ -110,6 +110,12 @@ namespace llvm { namespace sys { namespace fs { +TimeValue file_status::getLastModificationTime() { + TimeValue Ret; + Ret.fromEpochTime(fs_st_mtime); + return Ret; +} + error_code current_path(SmallVectorImpl &result) { #ifdef MAXPATHLEN result.reserve(MAXPATHLEN); @@ -401,6 +407,7 @@ error_code status(const Twine &path, file_status &result) { result.fs_st_dev = status.st_dev; result.fs_st_ino = status.st_ino; + result.fs_st_mtime = status.st_mtime; return error_code::success(); } diff --git a/lib/Support/Windows/PathV2.inc b/lib/Support/Windows/PathV2.inc index 8815b0ec2f7..006e31a5bd2 100644 --- a/lib/Support/Windows/PathV2.inc +++ b/lib/Support/Windows/PathV2.inc @@ -128,6 +128,16 @@ namespace llvm { namespace sys { namespace fs { +TimeValue file_status::getLastModificationTime() { + ULARGE_INTEGER UI; + UI.LowPart = LastWriteTimeLow; + UI.HighPart = LastWriteTimeHigh; + + TimeValue Ret; + Ret.fromWin32Time(UI.QuadPart); + return Ret; +} + error_code current_path(SmallVectorImpl &result) { SmallVector cur_path; cur_path.reserve(128); diff --git a/tools/llvm-ar/llvm-ar.cpp b/tools/llvm-ar/llvm-ar.cpp index 4c986715aec..e422f310c6b 100644 --- a/tools/llvm-ar/llvm-ar.cpp +++ b/tools/llvm-ar/llvm-ar.cpp @@ -583,15 +583,14 @@ doReplaceOrInsert(std::string* ErrMsg) { } if (found != remaining.end()) { - std::string Err; - sys::PathWithStatus PwS(*found); - const sys::FileStatus *si = PwS.getFileStatus(false, &Err); - if (!si) + sys::fs::file_status Status; + error_code EC = sys::fs::status(*found, Status); + if (EC) return true; - if (!si->isDir) { + if (!sys::fs::is_directory(Status)) { if (OnlyUpdate) { // Replace the item only if it is newer. - if (si->modTime > I->getModTime()) + if (Status.getLastModificationTime() > I->getModTime()) if (I->replaceWith(*found, ErrMsg)) return true; } else {