From 2ca895612c9b4404beb2eafdb47b3997abd036bf Mon Sep 17 00:00:00 2001 From: Kevin Enderby Date: Fri, 9 Jan 2015 21:55:03 +0000 Subject: [PATCH] Fix an ASAN failure introduced with r225537 (adding the -universal-headers to llvm-obdump). And a fly by fix to some formatting issues with the same commit. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@225550 91177308-0d34-0410-b5e6-96231b3b80d8 --- tools/llvm-objdump/MachODump.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/llvm-objdump/MachODump.cpp b/tools/llvm-objdump/MachODump.cpp index 153edfab52c..657f3624739 100644 --- a/tools/llvm-objdump/MachODump.cpp +++ b/tools/llvm-objdump/MachODump.cpp @@ -475,12 +475,12 @@ static void printMachOUniversalHeaders(const object::MachOUniversalBinary *UB, MachOUniversalBinary::ObjectForArch other_OFA(UB, j); uint32_t other_cputype = other_OFA.getCPUType(); uint32_t other_cpusubtype = other_OFA.getCPUSubType(); - if (cputype != 0 && cpusubtype != 0 && - cputype == other_cputype && + if (cputype != 0 && cpusubtype != 0 && cputype == other_cputype && (cpusubtype & ~MachO::CPU_SUBTYPE_MASK) == - (other_cpusubtype & ~MachO::CPU_SUBTYPE_MASK)) + (other_cpusubtype & ~MachO::CPU_SUBTYPE_MASK)) { outs() << "(illegal duplicate architecture) "; break; + } } if (verbose) { outs() << OFA.getArchTypeName() << "\n"; @@ -611,11 +611,11 @@ void llvm::ParseInputMachO(StringRef Filename) { // No architecture flags were specified so if this contains a slice that // matches the host architecture dump only that. if (!ArchAll) { - StringRef HostArchName = MachOObjectFile::getHostArch().getArchName(); for (MachOUniversalBinary::object_iterator I = UB->begin_objects(), E = UB->end_objects(); I != E; ++I) { - if (HostArchName == I->getArchTypeName()) { + if (MachOObjectFile::getHostArch().getArchName() == + I->getArchTypeName()) { ErrorOr> ObjOrErr = I->getAsObjectFile(); std::string ArchiveName; ArchiveName.clear();