6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-09-26 09:18:56 +00:00
Code Issues Projects Releases Wiki Activity

ObjectSizeOffsetEvaluator: Don't run into infinite recursion if we have a cyclic GEP.

Browse Source 
Those can occur in dead code. PR17402.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@191644 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Benjamin Kramer
2013-09-29 19:39:13 +00:00
parent 67a2553749
commit 2f08433210
2 changed files with 24 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
lib/Analysis/MemoryBuiltins.cpp
View File

@@ -634,13 +634,15 @@ SizeOffsetEvalType ObjectSizeOffsetEvaluator::compute_(Value *V) {
if (Instruction *I = dyn_cast<Instruction>(V)) if (Instruction *I = dyn_cast<Instruction>(V))
Builder.SetInsertPoint(I); Builder.SetInsertPoint(I);
// record the pointers that were handled in this run, so that they can be
// cleaned later if something fails
SeenVals.insert(V);
// now compute the size and offset // now compute the size and offset
SizeOffsetEvalType Result; SizeOffsetEvalType Result;
if (GEPOperator *GEP = dyn_cast<GEPOperator>(V)) {
// Record the pointers that were handled in this run, so that they can be
// cleaned later if something fails. We also use this set to break cycles that
// can occur in dead code.
if (!SeenVals.insert(V)) {
Result = unknown();
} else if (GEPOperator *GEP = dyn_cast<GEPOperator>(V)) {
Result = visitGEPOperator(*GEP); Result = visitGEPOperator(*GEP);
} else if (Instruction *I = dyn_cast<Instruction>(V)) { } else if (Instruction *I = dyn_cast<Instruction>(V)) {
Result = visit(*I); Result = visit(*I);

17
test/Instrumentation/BoundsChecking/simple.ll
View File

@@ -126,3 +126,20 @@ define i64 @f12(i64 %x, i64 %y) nounwind {
%4 = load i64* %3, align 8 %4 = load i64* %3, align 8
ret i64 %4 ret i64 %4
} }
; PR17402
; CHECK-LABEL: @f13
define void @f13() nounwind {
entry:
br label %alive
dead:
; Self-refential GEPs can occur in dead code.
%incdec.ptr = getelementptr inbounds i32* %incdec.ptr, i64 1
; CHECK: %incdec.ptr = getelementptr inbounds i32* %incdec.ptr
%l = load i32* %incdec.ptr
br label %alive
alive:
ret void
}