6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-10-08 02:19:05 +00:00
Code Issues Projects Releases Wiki Activity

IR: Disallow complicated function-local metadata

Browse Source 
Disallow complex types of function-local metadata.  The only valid
function-local metadata is an `MDNode` whose sole argument is a
non-metadata function-local value.

Part of PR21532.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@223564 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Duncan P. N. Exon Smith
2014-12-06 01:26:49 +00:00
parent ab1837aef3
commit 30596886ed
6 changed files with 81 additions and 66 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
lib/Bitcode/Reader/BitcodeReader.cpp
View File

@@ -1072,7 +1072,6 @@ std::error_code BitcodeReader::ParseMetadata() {
break;
}
bool IsFunctionLocal = false;
// Read a record.
Record.clear();
unsigned Code = Stream.readRecord(Entry.ID, Record);
@@ -1100,9 +1099,34 @@ std::error_code BitcodeReader::ParseMetadata() {
}
break;
}
case bitc::METADATA_FN_NODE:
IsFunctionLocal = true;
// fall-through
case bitc::METADATA_FN_NODE: {
// This is a function-local node.
if (Record.size() % 2 == 1)
return Error(BitcodeError::InvalidRecord);
// If this isn't a single-operand node that directly references
// non-metadata, we're dropping it. This used to be legal, but there's
// no upgrade path.
auto dropRecord = [&] {
MDValueList.AssignValue(MDNode::get(Context, None), NextMDValueNo++);
};
if (Record.size() != 2) {
dropRecord();
break;
}
Type *Ty = getTypeByID(Record[0]);
if (Ty->isMetadataTy() || Ty->isVoidTy()) {
dropRecord();
break;
}
Value *Elts[] = {ValueList.getValueFwdRef(Record[1], Ty)};
Value *V = MDNode::getWhenValsUnresolved(Context, Elts,
/*IsFunctionLocal*/ true);
MDValueList.AssignValue(V, NextMDValueNo++);
break;
}
case bitc::METADATA_NODE: {
if (Record.size() % 2 == 1)
return Error(BitcodeError::InvalidRecord);
@@ -1120,8 +1144,8 @@ std::error_code BitcodeReader::ParseMetadata() {
else
Elts.push_back(nullptr);
}
Value *V = MDNode::getWhenValsUnresolved(Context, Elts, IsFunctionLocal);
IsFunctionLocal = false;
Value *V = MDNode::getWhenValsUnresolved(Context, Elts,
/*IsFunctionLocal*/ false);
MDValueList.AssignValue(V, NextMDValueNo++);
break;
}