6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-02-06 06:33:24 +00:00
Code Issues Projects Releases Wiki Activity

[mips] '.set at=$0' should be equivalent to '.set noat'

Browse Source 
Differential Revision: http://llvm-reviews.chandlerc.com/D3171

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204714 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Daniel Sanders 2014-03-25 13:01:06 +00:00
parent 3ec862b7ae
commit 3527e5fcb3
3 changed files with 15 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/Target/Mips/AsmParser/MipsAsmParser.cpp
View File

@ -2352,7 +2352,7 @@ bool MipsAsmParser::parseSetAtDirective() {
return false; return false;
} }
if (AtRegNo < 1 || AtRegNo > 31) { if (AtRegNo < 0 || AtRegNo > 31) {
reportParseError("unexpected token in statement"); reportParseError("unexpected token in statement");
return false; return false;
} }

15
test/MC/Mips/mips-noat.s
View File

@ -1,7 +1,8 @@
# RUN: not llvm-mc %s -triple=mips-unknown-linux 2>%t0 | FileCheck %s # RUN: not llvm-mc %s -triple=mips-unknown-linux 2>%t0 | FileCheck %s
# RUN: FileCheck -check-prefix=ERROR %s < %t0 # RUN: FileCheck -check-prefix=ERROR %s < %t0
# Check that using the assembler temporary when .set noat is in effect is an error.
# We start with $at enabled # We start with the assembler temporary enabled
# CHECK-LABEL: test1: # CHECK-LABEL: test1:
# CHECK: lui $1, 1 # CHECK: lui $1, 1
# CHECK: addu $1, $1, $2 # CHECK: addu $1, $1, $2
@ -9,10 +10,8 @@
test1: test1:
lw $2, 65536($2) lw $2, 65536($2)
# Check that using $at when .set noat is in effect is an error.
# FIXME: It would be better if the error pointed at the mnemonic instead of the newline # FIXME: It would be better if the error pointed at the mnemonic instead of the newline
# ERROR: mips-noat.s:[[@LINE+5]]:1: error: Pseudo instruction requires $at, which is not available # ERROR: mips-noat.s:[[@LINE+4]]:1: error: Pseudo instruction requires $at, which is not available
# ERROR-NOT: error
test2: test2:
.set noat .set noat
lw $2, 65536($2) lw $2, 65536($2)
@ -25,3 +24,11 @@ test2:
test3: test3:
.set at .set at
lw $2, 65536($2) lw $2, 65536($2)
# FIXME: It would be better if the error pointed at the mnemonic instead of the newline
# ERROR: mips-noat.s:[[@LINE+4]]:1: error: Pseudo instruction requires $at, which is not available
test4:
.set at=$0
lw $2, 65536($2)
# ERROR-NOT: error

3
test/MC/Mips/set-at-directive-explicit-at.s
View File

@ -26,6 +26,9 @@ foo:
# CHECK: jr $1 # encoding: [0x08,0x00,0x20,0x00] # CHECK: jr $1 # encoding: [0x08,0x00,0x20,0x00]
.set noat .set noat
jr $at jr $at
# CHECK: jr $1 # encoding: [0x08,0x00,0x20,0x00]
.set at=$0
jr $at
# CHECK: jr $16 # encoding: [0x08,0x00,0x00,0x02] # CHECK: jr $16 # encoding: [0x08,0x00,0x00,0x02]
# WARNINGS: :[[@LINE+2]]:12: warning: Used $16 with ".set at=$16" # WARNINGS: :[[@LINE+2]]:12: warning: Used $16 with ".set at=$16"