mirror of
https://github.com/c64scene-ar/llvm-6502.git
synced 2025-06-25 16:24:23 +00:00
Re-commit: Demote EmitRawText call in AsmPrinter::EmitInlineAsm() and remove hasRawTextSupport() call
Summary: AsmPrinter::EmitInlineAsm() will no longer use the EmitRawText() call for targets with mature MC support. Such targets will always parse the inline assembly (even when emitting assembly). Targets without mature MC support continue to use EmitRawText() for assembly output. The hasRawTextSupport() check in AsmPrinter::EmitInlineAsm() has been replaced with MCAsmInfo::UseIntegratedAs which when true, causes the integrated assembler to parse inline assembly (even when emitting assembly output). UseIntegratedAs is set to true for targets that consider any failure to parse valid assembly to be a bug. Target specific subclasses generally enable the integrated assembler in their constructor. The default value can be overridden with -no-integrated-as. All tests that rely on inline assembly supporting invalid assembly (for example, those that use mnemonics such as 'foo' or 'hello world') have been updated to disable the integrated assembler. Changes since review (and last commit attempt): - Fixed test failures that were missed due to configuration of local build. (fixes crash.ll and a couple others). - Fixed tests that happened to pass because the local build was on X86 (should fix 2007-12-17-InvokeAsm.ll) - mature-mc-support.ll's should no longer require all targets to be compiled. (should fix ARM and PPC buildbots) - Object output (-filetype=obj and similar) now forces the integrated assembler to be enabled regardless of default setting or -no-integrated-as. (should fix SystemZ buildbots) Reviewers: rafael Reviewed By: rafael CC: llvm-commits Differential Revision: http://llvm-reviews.chandlerc.com/D2686 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@201333 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
@ -299,6 +299,14 @@ namespace llvm {
|
||||
|
||||
std::vector<MCCFIInstruction> InitialFrameState;
|
||||
|
||||
//===--- Integrated Assembler State ----------------------------------===//
|
||||
/// Should we use the integrated assembler?
|
||||
/// The integrated assembler should be enabled by default (by the
|
||||
/// constructors) when failing to parse a valid piece of assembly (inline
|
||||
/// or otherwise) is considered a bug. It may then be overridden after
|
||||
/// construction (see LLVMTargetMachine::initAsmInfo()).
|
||||
bool UseIntegratedAssembler;
|
||||
|
||||
public:
|
||||
explicit MCAsmInfo();
|
||||
virtual ~MCAsmInfo();
|
||||
@ -526,6 +534,14 @@ namespace llvm {
|
||||
const std::vector<MCCFIInstruction> &getInitialFrameState() const {
|
||||
return InitialFrameState;
|
||||
}
|
||||
|
||||
/// Return true if assembly (inline or otherwise) should be parsed.
|
||||
bool useIntegratedAssembler() const { return UseIntegratedAssembler; }
|
||||
|
||||
/// Set whether assembly (inline or otherwise) should be parsed.
|
||||
void setUseIntegratedAssembler(bool Value) {
|
||||
UseIntegratedAssembler = Value;
|
||||
}
|
||||
};
|
||||
}
|
||||
|
||||
|
@ -51,6 +51,9 @@ public:
|
||||
/// state management
|
||||
virtual void reset();
|
||||
|
||||
/// Object streamers require the integrated assembler.
|
||||
virtual bool isIntegratedAssemblerRequired() const { return true; }
|
||||
|
||||
protected:
|
||||
MCSectionData *getCurrentSectionData() const {
|
||||
return CurSectionData;
|
||||
|
@ -75,6 +75,8 @@ public:
|
||||
MCTargetStreamer(MCStreamer &S);
|
||||
virtual ~MCTargetStreamer();
|
||||
|
||||
const MCStreamer &getStreamer() { return Streamer; }
|
||||
|
||||
// Allow a target to add behavior to the EmitLabel of MCStreamer.
|
||||
virtual void emitLabel(MCSymbol *Symbol);
|
||||
|
||||
@ -233,6 +235,10 @@ public:
|
||||
/// unformatted text to the .s file with EmitRawText.
|
||||
virtual bool hasRawTextSupport() const { return false; }
|
||||
|
||||
/// Is the integrated assembler required for this streamer to function
|
||||
/// correctly?
|
||||
virtual bool isIntegratedAssemblerRequired() const { return false; }
|
||||
|
||||
/// AddComment - Add a comment that can be emitted to the generated .s
|
||||
/// file if applicable as a QoI issue to make the output of the compiler
|
||||
/// more readable. This only affects the MCAsmStreamer, and only when
|
||||
|
Reference in New Issue
Block a user