From 3974ade503c14fb7c7db32e0032b77b5c55e6ea4 Mon Sep 17 00:00:00 2001 From: Johnny Chen Date: Tue, 20 Apr 2010 01:01:57 +0000 Subject: [PATCH] Better error-handling for DisassembleThumb2DPModImm() with 2-reg operands where d==15 is considered illegal. Return false instead of assert(). git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@101852 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Target/ARM/Disassembler/ThumbDisassemblerCore.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/Target/ARM/Disassembler/ThumbDisassemblerCore.h b/lib/Target/ARM/Disassembler/ThumbDisassemblerCore.h index 001d0c6dff5..a3d7ffe52e4 100644 --- a/lib/Target/ARM/Disassembler/ThumbDisassemblerCore.h +++ b/lib/Target/ARM/Disassembler/ThumbDisassemblerCore.h @@ -1413,7 +1413,10 @@ static bool DisassembleThumb2DPModImm(MCInst &MI, unsigned Opcode, ++OpIdx; if (TwoReg) { - assert(!NoDstReg && "Internal error"); + if (NoDstReg) { + DEBUG(errs() << "Thumb encoding error: d==15 for DPModImm 2-reg instr.\n"); + return false; + } MI.addOperand(MCOperand::CreateReg(getRegisterEnum(B, ARM::GPRRegClassID, decodeRn(insn)))); ++OpIdx;