Optimize sprintf -> siprintf if there are no floating point arguments

and siprintf is available on the target.



git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@126937 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Richard Osborne 2011-03-03 14:09:28 +00:00
parent 12785e87e8
commit 419454ad37
4 changed files with 56 additions and 10 deletions

View File

@ -29,6 +29,9 @@ namespace llvm {
/// int iprintf(const char *format, ...);
iprintf,
/// int siprintf(char *str, const char *format, ...);
siprintf,
NumLibFuncs
};
}

View File

@ -31,9 +31,11 @@ static void initialize(TargetLibraryInfo &TLI, const Triple &T) {
if (T.getOS() != Triple::Darwin || T.getDarwinMajorNumber() < 9)
TLI.setUnavailable(LibFunc::memset_pattern16);
// iprintf is only available on XCore.
if (T.getArch() != Triple::xcore)
// iprintf and friends are only available on XCore.
if (T.getArch() != Triple::xcore) {
TLI.setUnavailable(LibFunc::iprintf);
TLI.setUnavailable(LibFunc::siprintf);
}
}

View File

@ -1176,14 +1176,8 @@ struct PrintFOpt : public LibCallOptimization {
// 'sprintf' Optimizations
struct SPrintFOpt : public LibCallOptimization {
virtual Value *CallOptimizer(Function *Callee, CallInst *CI, IRBuilder<> &B) {
// Require two fixed pointer arguments and an integer result.
const FunctionType *FT = Callee->getFunctionType();
if (FT->getNumParams() != 2 || !FT->getParamType(0)->isPointerTy() ||
!FT->getParamType(1)->isPointerTy() ||
!FT->getReturnType()->isIntegerTy())
return 0;
Value *OptimizeFixedFormatString(Function *Callee, CallInst *CI,
IRBuilder<> &B) {
// Check for a fixed format string.
std::string FormatStr;
if (!GetConstantStringInfo(CI->getArgOperand(1), FormatStr))
@ -1244,6 +1238,32 @@ struct SPrintFOpt : public LibCallOptimization {
}
return 0;
}
virtual Value *CallOptimizer(Function *Callee, CallInst *CI, IRBuilder<> &B) {
// Require two fixed pointer arguments and an integer result.
const FunctionType *FT = Callee->getFunctionType();
if (FT->getNumParams() != 2 || !FT->getParamType(0)->isPointerTy() ||
!FT->getParamType(1)->isPointerTy() ||
!FT->getReturnType()->isIntegerTy())
return 0;
if (Value *V = OptimizeFixedFormatString(Callee, CI, B)) {
return V;
}
// sprintf(str, format, ...) -> iprintf(str, format, ...) if no floating
// point arguments.
if (TLI->has(LibFunc::siprintf) && !CallHasFloatingPointArgument(CI)) {
Module *M = B.GetInsertBlock()->getParent()->getParent();
Constant *SIPrintFFn =
M->getOrInsertFunction("siprintf", FT, Callee->getAttributes());
CallInst *New = cast<CallInst>(CI->clone());
New->setCalledFunction(SIPrintFFn);
B.Insert(New);
return New;
}
return 0;
}
};
//===---------------------------------------===//

View File

@ -26,4 +26,25 @@ entry:
ret void
}
; Verify sprintf with no floating point arguments is transformed to siprintf
define i32 @f2(i8* %p, i32 %x) nounwind {
entry:
; CHECK: define i32 @f2
; CHECK: @siprintf
; CHECK: }
%0 = tail call i32 (i8*, i8*, ...)* @sprintf(i8 *%p, i8* getelementptr ([4 x i8]* @.str1, i32 0, i32 0), i32 %x)
ret i32 %0
}
; Verify we don't turn this into an siprintf call
define i32 @f3(i8* %p, double %x) nounwind {
entry:
; CHECK: define i32 @f3
; CHECK: @sprintf
; CHECK: }
%0 = tail call i32 (i8*, i8*, ...)* @sprintf(i8 *%p, i8* getelementptr ([4 x i8]* @.str, i32 0, i32 0), double %x)
ret i32 %0
}
declare i32 @printf(i8* nocapture, ...) nounwind
declare i32 @sprintf(i8* nocapture, i8* nocapture, ...) nounwind