[C++11] Replace LLVM atomics with std::atomic.

With C++11 we finally have a standardized way to specify atomic operations. Use
them to replace the existing custom implemention. Sadly the translation is not
entirely trivial as std::atomic allows more fine-grained control over the
atomicity. I tried to preserve the old semantics as well as possible.

Differential Revision: http://llvm-reviews.chandlerc.com/D2915

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202730 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Benjamin Kramer
2014-03-03 17:53:30 +00:00
parent 59a4517759
commit 4721e55a0c
9 changed files with 49 additions and 41 deletions

View File

@@ -13,7 +13,6 @@
#include "llvm/Support/ManagedStatic.h"
#include "llvm/Config/config.h"
#include "llvm/Support/Atomic.h"
#include <cassert>
using namespace llvm;
@@ -28,7 +27,7 @@ void ManagedStaticBase::RegisterManagedStatic(void *(*Creator)(),
void* tmp = Creator ? Creator() : 0;
TsanHappensBefore(this);
sys::MemoryFence();
std::atomic_thread_fence(std::memory_order_seq_cst);
// This write is racy against the first read in the ManagedStatic
// accessors. The race is benign because it does a second read after a

View File

@@ -76,7 +76,7 @@ void Statistic::RegisterStatistic() {
StatInfo->addStatistic(this);
TsanHappensBefore(this);
sys::MemoryFence();
std::atomic_thread_fence(std::memory_order_seq_cst);
// Remember we have been registered.
TsanIgnoreWritesBegin();
Initialized = true;

View File

@@ -13,8 +13,8 @@
#include "llvm/Support/Threading.h"
#include "llvm/Config/config.h"
#include "llvm/Support/Atomic.h"
#include "llvm/Support/Mutex.h"
#include <atomic>
#include <cassert>
using namespace llvm;
@@ -31,7 +31,7 @@ bool llvm::llvm_start_multithreaded() {
// We fence here to ensure that all initialization is complete BEFORE we
// return from llvm_start_multithreaded().
sys::MemoryFence();
std::atomic_thread_fence(std::memory_order_seq_cst);
return true;
#else
return false;
@@ -44,7 +44,7 @@ void llvm::llvm_stop_multithreaded() {
// We fence here to insure that all threaded operations are complete BEFORE we
// return from llvm_stop_multithreaded().
sys::MemoryFence();
std::atomic_thread_fence(std::memory_order_seq_cst);
multithreaded_mode = false;
delete global_lock;

View File

@@ -81,14 +81,14 @@ raw_ostream *llvm::CreateInfoOutputFile() {
static TimerGroup *DefaultTimerGroup = 0;
static TimerGroup *getDefaultTimerGroup() {
TimerGroup *tmp = DefaultTimerGroup;
sys::MemoryFence();
std::atomic_thread_fence(std::memory_order_seq_cst);
if (tmp) return tmp;
llvm_acquire_global_lock();
tmp = DefaultTimerGroup;
if (!tmp) {
tmp = new TimerGroup("Miscellaneous Ungrouped Timers");
sys::MemoryFence();
std::atomic_thread_fence(std::memory_order_seq_cst);
DefaultTimerGroup = tmp;
}
llvm_release_global_lock();