6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-01-03 13:31:05 +00:00
Code Issues Projects Releases Wiki Activity

Remove SetWorkingDirectory from the Process interface. Nothing in LLVM

Browse Source 
or Clang is using this, and it would be hard to use it correctly given
the thread hostility of the function. Also, it never checked the return
which is rather dangerous with chdir. If someone was in fact using this,
please let me know, as well as what the usecase actually is so that
I can add it back and make it more correct and secure to use. (That
said, it's never going to be "safe" per-se, but we could at least
document the risks...)

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@148211 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Chandler Carruth 2012-01-15 08:41:35 +00:00
parent 49c0a9ac98
commit 4aab4ab340
3 changed files with 0 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
include/llvm/Support/Process.h
View File

@ -138,9 +138,6 @@ namespace sys {
/// Resets the terminals colors, or returns an escape sequence to do so.
static const char *ResetColor();
/// Change the program working directory to that given by \arg Path.
static void SetWorkingDirectory(std::string Path);
/// @}
};
}

4
lib/Support/Unix/Process.inc
View File

@ -293,7 +293,3 @@ const char *Process::OutputBold(bool bg) {
const char *Process::ResetColor() {
return "\033[0m";
}
void Process::SetWorkingDirectory(std::string Path) {
::chdir(Path.c_str());
}

4
lib/Support/Windows/Process.inc
View File

@ -220,8 +220,4 @@ const char *Process::ResetColor() {
return 0;
}
void Process::SetWorkingDirectory(std::string Path) {
::_chdir(Path.c_str());
}
}