From 4aab4ab340863d87f9c566b69099ce60dd8762be Mon Sep 17 00:00:00 2001 From: Chandler Carruth Date: Sun, 15 Jan 2012 08:41:35 +0000 Subject: [PATCH] Remove SetWorkingDirectory from the Process interface. Nothing in LLVM or Clang is using this, and it would be hard to use it correctly given the thread hostility of the function. Also, it never checked the return which is rather dangerous with chdir. If someone was in fact using this, please let me know, as well as what the usecase actually is so that I can add it back and make it more correct and secure to use. (That said, it's never going to be "safe" per-se, but we could at least document the risks...) git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@148211 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/llvm/Support/Process.h | 3 --- lib/Support/Unix/Process.inc | 4 ---- lib/Support/Windows/Process.inc | 4 ---- 3 files changed, 11 deletions(-) diff --git a/include/llvm/Support/Process.h b/include/llvm/Support/Process.h index 27ef2670093..33799229ff3 100644 --- a/include/llvm/Support/Process.h +++ b/include/llvm/Support/Process.h @@ -138,9 +138,6 @@ namespace sys { /// Resets the terminals colors, or returns an escape sequence to do so. static const char *ResetColor(); - - /// Change the program working directory to that given by \arg Path. - static void SetWorkingDirectory(std::string Path); /// @} }; } diff --git a/lib/Support/Unix/Process.inc b/lib/Support/Unix/Process.inc index da440fd48f3..5cdb11ccebc 100644 --- a/lib/Support/Unix/Process.inc +++ b/lib/Support/Unix/Process.inc @@ -293,7 +293,3 @@ const char *Process::OutputBold(bool bg) { const char *Process::ResetColor() { return "\033[0m"; } - -void Process::SetWorkingDirectory(std::string Path) { - ::chdir(Path.c_str()); -} diff --git a/lib/Support/Windows/Process.inc b/lib/Support/Windows/Process.inc index fe54eb1a797..913b0734ddc 100644 --- a/lib/Support/Windows/Process.inc +++ b/lib/Support/Windows/Process.inc @@ -220,8 +220,4 @@ const char *Process::ResetColor() { return 0; } -void Process::SetWorkingDirectory(std::string Path) { - ::_chdir(Path.c_str()); -} - }