mirror of
https://github.com/c64scene-ar/llvm-6502.git
synced 2025-01-10 02:36:06 +00:00
add a fixme, ELF MCSection isn't quite right and weak unnamed globals are broken
on linux (even though they are pointless, they shouldn't ICE). git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@93308 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
parent
57d1d936fc
commit
4d5f06fbe5
@ -578,6 +578,10 @@ SelectSectionForGlobal(const GlobalValue *GV, SectionKind Kind,
|
|||||||
const char *Prefix = getSectionPrefixForUniqueGlobal(Kind);
|
const char *Prefix = getSectionPrefixForUniqueGlobal(Kind);
|
||||||
SmallString<128> Name;
|
SmallString<128> Name;
|
||||||
Name.append(Prefix, Prefix+strlen(Prefix));
|
Name.append(Prefix, Prefix+strlen(Prefix));
|
||||||
|
// FIXME: This will fail for weak globals with no names, this also depends
|
||||||
|
// on the mangling behavior of makeNameProper to mangle the section name
|
||||||
|
// before construction. Instead, this should use getNameWithPrefix on the
|
||||||
|
// global variable and the MCSection printing code should do the mangling.
|
||||||
Mang->makeNameProper(Name, GV->getName());
|
Mang->makeNameProper(Name, GV->getName());
|
||||||
|
|
||||||
return getELFSection(Name.str(),
|
return getELFSection(Name.str(),
|
||||||
|
Loading…
x
Reference in New Issue
Block a user