From 4ef6a7bf69a7a53600ad1dc04277b1e3d451869c Mon Sep 17 00:00:00 2001 From: Justin Bogner Date: Fri, 28 Feb 2014 19:08:01 +0000 Subject: [PATCH] CommandLine: Exit successfully for -version and -help Tools that use the CommandLine library currently exit with an error when invoked with -version or -help. This is unusual and non-standard, so we'll fix them to exit successfully instead. I don't expect that anyone relies on the current behaviour, so this should be a fairly safe change. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202530 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Support/CommandLine.cpp | 6 +++--- test/CodeGen/Generic/print-after.ll | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/Support/CommandLine.cpp b/lib/Support/CommandLine.cpp index e1317a25986..9e807265878 100644 --- a/lib/Support/CommandLine.cpp +++ b/lib/Support/CommandLine.cpp @@ -1496,7 +1496,7 @@ public: MoreHelp->clear(); // Halt the program since help information was printed - exit(1); + exit(0); } }; @@ -1732,7 +1732,7 @@ public: if (OverrideVersionPrinter != 0) { (*OverrideVersionPrinter)(); - exit(1); + exit(0); } print(); @@ -1746,7 +1746,7 @@ public: (*I)(); } - exit(1); + exit(0); } }; } // End anonymous namespace diff --git a/test/CodeGen/Generic/print-after.ll b/test/CodeGen/Generic/print-after.ll index 7505907ef77..1b7ce84a8a5 100644 --- a/test/CodeGen/Generic/print-after.ll +++ b/test/CodeGen/Generic/print-after.ll @@ -1,4 +1,4 @@ -; RUN: not llc --help-hidden 2>&1 | FileCheck %s +; RUN: llc --help-hidden 2>&1 | FileCheck %s ; CHECK: -print-after ; CHECK-NOT: -print-after-all