6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-07-06 01:24:35 +00:00
Code Issues Projects Releases Wiki Activity

Add a FIXME for PR22796, broken ordering of ClassInfo in TableGen

Browse Source 
As discussed (at length) in code review of r222935, with Duncan.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@231282 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
David Blaikie
2015-03-04 19:56:44 +00:00
parent 671944ff8f
commit 5109ec06a6
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
utils/TableGen/AsmMatcherEmitter.cpp
View File

@ -264,6 +264,11 @@ public:
} }
/// operator< - Compare two classes. /// operator< - Compare two classes.
// FIXME: This ordering seems to be broken. For example:
// u64 < i64, i64 < s8, s8 < u64, forming a cycle
// u64 is a subset of i64
// i64 and s8 are not subsets of each other, so are ordered by name
// s8 and u64 are not subsets of each other, so are ordered by name
bool operator<(const ClassInfo &RHS) const { bool operator<(const ClassInfo &RHS) const {
if (this == &RHS) if (this == &RHS)
return false; return false;