6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2024-12-29 10:32:47 +00:00
Code Issues Projects Releases Wiki Activity

GlobalOpt: fix an issue where CXAAtExitFn points to a deleted function.

Browse Source 
CXAAtExitFn was set outside a loop and before optimizations where functions
can be deleted. This patch will set CXAAtExitFn inside the loop and after
optimizations.

Seg fault when running LTO because of accesses to a deleted function.
rdar://problem/13838828


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181838 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Manman Ren 2013-05-14 21:52:44 +00:00
parent e83a6f32a4
commit 5150270d07
2 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/Transforms/IPO/GlobalOpt.cpp
View File

@ -3323,8 +3323,6 @@ bool GlobalOpt::runOnModule(Module &M) {
// Try to find the llvm.globalctors list. // Try to find the llvm.globalctors list.
GlobalVariable *GlobalCtors = FindGlobalCtors(M); GlobalVariable *GlobalCtors = FindGlobalCtors(M);
Function *CXAAtExitFn = FindCXAAtExit(M, TLI);
bool LocalChange = true; bool LocalChange = true;
while (LocalChange) { while (LocalChange) {
LocalChange = false; LocalChange = false;
@ -3342,7 +3340,9 @@ bool GlobalOpt::runOnModule(Module &M) {
// Resolve aliases, when possible. // Resolve aliases, when possible.
LocalChange |= OptimizeGlobalAliases(M); LocalChange |= OptimizeGlobalAliases(M);
// Try to remove trivial global destructors. // Try to remove trivial global destructors if they are not removed
// already.
Function *CXAAtExitFn = FindCXAAtExit(M, TLI);
if (CXAAtExitFn) if (CXAAtExitFn)
LocalChange |= OptimizeEmptyGlobalCXXDtors(CXAAtExitFn); LocalChange |= OptimizeEmptyGlobalCXXDtors(CXAAtExitFn);

6
test/Transforms/GlobalOpt/atexit.ll Normal file
View File

@ -0,0 +1,6 @@
; RUN: opt < %s -globalopt -S | FileCheck %s
; CHECK: ModuleID
define internal hidden i32 @__cxa_atexit(void (i8*)* nocapture %func, i8* nocapture %arg, i8* nocapture %dso_handle) nounwind readnone optsize noimplicitfloat {
unreachable
}