6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-02-08 06:32:24 +00:00
Code Issues Projects Releases Wiki Activity

When creating X86ISD::INC and X86ISD::DEC nodes, only add one operand.

Browse Source 
The extra operand didn't appear to cause any trouble, but it was
erroneous regardless.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@66206 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Dan Gohman 2009-03-05 21:29:28 +00:00
parent 4bfcf2a2a6
commit 51bb47480e
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/Target/X86/X86ISelLowering.cpp
View File

@ -5370,6 +5370,7 @@ SDValue X86TargetLowering::EmitTest(SDValue Op, SelectionDAG &DAG) {
// doing a separate TEST. // doing a separate TEST.
if (Op.getResNo() == 0) { if (Op.getResNo() == 0) {
unsigned Opcode = 0; unsigned Opcode = 0;
unsigned NumOperands = 0;
switch (Op.getNode()->getOpcode()) { switch (Op.getNode()->getOpcode()) {
case ISD::ADD: case ISD::ADD:
// Due to an isel shortcoming, be conservative if this add is likely to // Due to an isel shortcoming, be conservative if this add is likely to
@ -5387,16 +5388,19 @@ SDValue X86TargetLowering::EmitTest(SDValue Op, SelectionDAG &DAG) {
// An add of one will be selected as an INC. // An add of one will be selected as an INC.
if (C->getAPIntValue() == 1) { if (C->getAPIntValue() == 1) {
Opcode = X86ISD::INC; Opcode = X86ISD::INC;
NumOperands = 1;
break; break;
} }
// An add of negative one (subtract of one) will be selected as a DEC. // An add of negative one (subtract of one) will be selected as a DEC.
if (C->getAPIntValue().isAllOnesValue()) { if (C->getAPIntValue().isAllOnesValue()) {
Opcode = X86ISD::DEC; Opcode = X86ISD::DEC;
NumOperands = 1;
break; break;
} }
} }
// Otherwise use a regular EFLAGS-setting add. // Otherwise use a regular EFLAGS-setting add.
Opcode = X86ISD::ADD; Opcode = X86ISD::ADD;
NumOperands = 2;
break; break;
case ISD::SUB: case ISD::SUB:
// Due to the ISEL shortcoming noted above, be conservative if this sub is // Due to the ISEL shortcoming noted above, be conservative if this sub is
@ -5407,6 +5411,7 @@ SDValue X86TargetLowering::EmitTest(SDValue Op, SelectionDAG &DAG) {
goto default_case; goto default_case;
// Otherwise use a regular EFLAGS-setting sub. // Otherwise use a regular EFLAGS-setting sub.
Opcode = X86ISD::SUB; Opcode = X86ISD::SUB;
NumOperands = 2;
break; break;
case X86ISD::ADD: case X86ISD::ADD:
case X86ISD::SUB: case X86ISD::SUB:
@ -5420,7 +5425,7 @@ SDValue X86TargetLowering::EmitTest(SDValue Op, SelectionDAG &DAG) {
if (Opcode != 0) { if (Opcode != 0) {
const MVT *VTs = DAG.getNodeValueTypes(Op.getValueType(), MVT::i32); const MVT *VTs = DAG.getNodeValueTypes(Op.getValueType(), MVT::i32);
SmallVector<SDValue, 4> Ops; SmallVector<SDValue, 4> Ops;
for (unsigned i = 0, e = Op.getNumOperands(); i != e; ++i) for (unsigned i = 0, e = NumOperands; i != e; ++i)
Ops.push_back(Op.getOperand(i)); Ops.push_back(Op.getOperand(i));
SDValue New = DAG.getNode(Opcode, dl, VTs, 2, &Ops[0], Ops.size()); SDValue New = DAG.getNode(Opcode, dl, VTs, 2, &Ops[0], Ops.size());
DAG.ReplaceAllUsesWith(Op, New); DAG.ReplaceAllUsesWith(Op, New);